Skip to content

Commit b0ff451

Browse files
committed
dmake: do not hard-code cli dependencies for testrunner target
1 parent 29c616f commit b0ff451

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ cppcheck: $(EXTOBJ) $(LIBOBJ) $(CLIOBJ)
348348

349349
all: cppcheck testrunner
350350

351-
testrunner: $(EXTOBJ) $(TESTOBJ) $(LIBOBJ) cli/executor.o cli/processexecutor.o cli/singleexecutor.o cli/threadexecutor.o cli/cmdlineparser.o cli/cppcheckexecutor.o cli/sehwrapper.o cli/signalhandler.o cli/stacktrace.o cli/filelister.o
351+
testrunner: $(EXTOBJ) $(TESTOBJ) $(LIBOBJ) cli/cmdlineparser.o cli/cppcheckexecutor.o cli/executor.o cli/filelister.o cli/processexecutor.o cli/sehwrapper.o cli/signalhandler.o cli/singleexecutor.o cli/stacktrace.o cli/threadexecutor.o
352352
$(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ $^ $(LIBS) $(LDFLAGS) $(RDYNAMIC)
353353

354354
test: all

tools/dmake/dmake.cpp

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -742,8 +742,15 @@ int main(int argc, char **argv)
742742
fout << "cppcheck: $(EXTOBJ) $(LIBOBJ) $(CLIOBJ)\n";
743743
fout << "\t$(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ $^ $(LIBS) $(LDFLAGS) $(RDYNAMIC)\n\n";
744744
fout << "all:\tcppcheck testrunner\n\n";
745-
// TODO: generate from clifiles
746-
fout << "testrunner: $(EXTOBJ) $(TESTOBJ) $(LIBOBJ) cli/executor.o cli/processexecutor.o cli/singleexecutor.o cli/threadexecutor.o cli/cmdlineparser.o cli/cppcheckexecutor.o cli/sehwrapper.o cli/signalhandler.o cli/stacktrace.o cli/filelister.o\n";
745+
std::string testrunner_clifiles_o;
746+
for (const std::string &clifile: clifiles) {
747+
if (clifile == "cli/main.cpp")
748+
continue;
749+
testrunner_clifiles_o += ' ';
750+
const std::string o = clifile.substr(0, clifile.length()-3) + 'o';
751+
testrunner_clifiles_o += o;
752+
}
753+
fout << "testrunner: $(EXTOBJ) $(TESTOBJ) $(LIBOBJ)" << testrunner_clifiles_o << "\n";
747754
fout << "\t$(CXX) $(CPPFLAGS) $(CXXFLAGS) -o $@ $^ $(LIBS) $(LDFLAGS) $(RDYNAMIC)\n\n";
748755
fout << "test:\tall\n";
749756
fout << "\t./testrunner\n\n";

0 commit comments

Comments
 (0)