Lexical preserving code attribute and new code list start attribute in callables#135
Merged
Conversation
…ing manner (so blank lines are not discarded); added codeStartLine attribute to callables Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR makes two changes. First, it updates the code attribute for callables and initializers to be lexical preserving (thus, not discarding blank lines), which ensures that relative line numbers within a code block with respect to the start of the code block can be used accurately. Second, the PR adds the
codeStartLineattribute to callables so that determining the start line of a code block does not require the application of heuristics on callable start line handling the formatting of callable annotations and declaration.How Has This Been Tested?
Tested with sample code and checked the updates attributes.
Breaking Changes
Types of changes
Checklist
Additional context