Addressing comments

lonnieezell · lonnieezell · commit 8e10faa21f0d · 2023-01-29T22:58:57.000-06:00
diff --git a/src/Filters/TokenAuth.php b/src/Filters/TokenAuth.php
@@ -50,7 +50,7 @@ public function before(RequestInterface $request, $arguments = null)
 
         if (! $result->isOK() || (! empty($arguments) && $result->extraInfo()->tokenCant($arguments[0]))) {
             return service('response')
-                ->setStatusCode(Response::HTTP_FORBIDDEN)
+                ->setStatusCode(Response::HTTP_UNAUTHORIZED)
                 ->setJson(['message' => lang('Auth.badToken')]);
         }
 
diff --git a/tests/Authentication/Filters/TokenFilterTest.php b/tests/Authentication/Filters/TokenFilterTest.php
@@ -24,7 +24,7 @@ public function testFilterNotAuthorized(): void
     {
         $result = $this->call('get', 'protected-route');
 
-        $result->assertStatus(403);
+        $result->assertStatus(401);
 
         $result = $this->get('open-route');
         $result->assertStatus(200);
@@ -84,7 +84,7 @@ public function testFiltersProtectsWithScopes(): void
         $result = $this->withHeaders(['Authorization' => 'Bearer ' . $token2->raw_token])
             ->get('protected-user-route');
 
-        $result->assertStatus(403);
+        $result->assertStatus(401);
     }
 
     public function testBlocksInactiveUsers(): void

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function before(RequestInterface $request, $arguments = null)`
`50`	`50`
`51`	`51`	`if (! $result->isOK() \|\| (! empty($arguments) && $result->extraInfo()->tokenCant($arguments[0]))) {`
`52`	`52`	`return service('response')`
`53`		`- ->setStatusCode(Response::HTTP_FORBIDDEN)`
	`53`	`+ ->setStatusCode(Response::HTTP_UNAUTHORIZED)`
`54`	`54`	`->setJson(['message' => lang('Auth.badToken')]);`
`55`	`55`	`}`
`56`	`56`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ public function testFilterNotAuthorized(): void`
`24`	`24`	`{`
`25`	`25`	`$result = $this->call('get', 'protected-route');`
`26`	`26`
`27`		`- $result->assertStatus(403);`
	`27`	`+ $result->assertStatus(401);`
`28`	`28`
`29`	`29`	`$result = $this->get('open-route');`
`30`	`30`	`$result->assertStatus(200);`
`@@ -84,7 +84,7 @@ public function testFiltersProtectsWithScopes(): void`
`84`	`84`	`$result = $this->withHeaders(['Authorization' => 'Bearer ' . $token2->raw_token])`
`85`	`85`	`->get('protected-user-route');`
`86`	`86`
`87`		`- $result->assertStatus(403);`
	`87`	`+ $result->assertStatus(401);`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`public function testBlocksInactiveUsers(): void`