format: format 0E-x where x > 6 like PostgreSQL does #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e8ffbf to
d163ccf
Compare
rafiss
approved these changes
May 12, 2023
rafiss
left a comment
There was a problem hiding this comment.
lgtm! but nit: since this is a lower level library used by others, i wonder if we should make the commit/comments say "PostgreSQL" instead of PG. ideally we'd not have to mention PG at all, but it sounds like we have to, since PG deviates from the official spec?
Contributor
Author
|
yep, done |
Officially in the GDA spec, formatting a 0 with any decimal places should be 0. However, this code doesn't do that - it formats the number of 0s up to 6, and then `0E-exponent` afterwards. To make this more "PG" compatible, we fix this by ensuring we display as many 0s as the exponent allows in the `.String()` case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Officially in the GDA spec, formatting a 0 with any decimal places should be 0. However, this code doesn't do that - it formats the number of 0s up to 6, and then
0E-exponentafterwards.To make this more "PG" compatible, we fix this by ensuring we display as many 0s as the exponent allows in the
.String()case.Refs cockroachdb/cockroach#102217, but not 100% sure I like the solution.