Skip to content

fix: Don't error when field has no metadata. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marianogappa merged 1 commit into from
Aug 14, 2024
Merged

fix: Don't error when field has no metadata. #221

marianogappa merged 1 commit into from
Aug 14, 2024

Conversation

@marianogappa
Copy link
Contributor

@marianogappa marianogappa commented Aug 14, 2024 •
edited
Loading

I implemented a PoC destination plugin in Python to prove it already supports destination plugins.

It does support them, but I encountered a small bug when processing fields with no metadata. This line errors:

plugin-sdk-python/cloudquery/sdk/schema/column.py

Line 63 in b3f898a

primary_key = metadata.get(arrow.METADATA_PRIMARY_KEY) == arrow.METADATA_TRUE

By simply adding an or {}, that error is gone.

I was able to implement a file destination in Python and sync XKCD into it:
Screenshot 2024-08-14 at 16 33 18

$ cli sync cloudquery-config                            ⏱ 15:58:33
Loading spec(s) from cloudquery-config
Starting sync for: xkcd (cloudquery/[email protected]) -> [file-python (grpc@localhost:7777)]
Sync completed successfully. Resources: 2970, Errors: 0, Warnings: 0, Time: 11s

@marianogappa marianogappa requested review from a team and erezrokah and removed request for a team August 14, 2024 15:34
erezrokah
erezrokah approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marianogappa marianogappa merged commit aac99a9 into main Aug 14, 2024
@marianogappa marianogappa deleted the mariano/enable-destination-plugins branch August 14, 2024 16:12
@cq-bot cq-bot mentioned this pull request Aug 14, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 14, 2024
@cq-bot
chore(main): Release v0.1.33 (#222)
c05de30 
🤖 I have created a release *beep* *boop*
---


## [0.1.33](v0.1.32...v0.1.33) (2024-08-14)


### Bug Fixes

* dont error when field has no metadata. ([#221](#221)) ([aac99a9](aac99a9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marianogappa @erezrokah