PR feedback

Author: heatlikeheatwave

packages/backend/src/api/endpoints/AccountlessApplicationsAPI.ts

@@ -5,26 +5,21 @@ import { AbstractAPI } from './AbstractApi';
 const basePath = '/accountless_applications';
 
 export class AccountlessApplicationAPI extends AbstractAPI {
-  public async createAccountlessApplication(headers: Headers) {
-    const headerParams = headers instanceof Headers ? Object.fromEntries(headers.entries()) : undefined;
+  public async createAccountlessApplication(params?: { requestHeaders?: Headers }) {
+    const headerParams = params?.requestHeaders ? Object.fromEntries(params.requestHeaders.entries()) : undefined;
     return this.request<AccountlessApplication>({
       method: 'POST',
       path: basePath,
       headerParams,
     });
   }
 
-  public async completeAccountlessApplicationOnboarding(headers: Headers) {
-    const headerParams = headers instanceof Headers ? Object.fromEntries(headers.entries()) : undefined;
-
+  public async completeAccountlessApplicationOnboarding(params?: { requestHeaders?: Headers }) {
+    const headerParams = params?.requestHeaders ? Object.fromEntries(params.requestHeaders.entries()) : undefined;
     return this.request<AccountlessApplication>({
       method: 'POST',
       path: joinPaths(basePath, 'complete'),
       headerParams,
     });
   }
-
-  public async abandonAccountlessApplication() {
-    // TODO: Implement abandon functionality
-  }
 }

packages/nextjs/src/app-router/server/keyless-provider.tsx

@@ -98,16 +98,15 @@ export const KeylessProvider = async (props: KeylessProviderProps) => {
        * If the request fails, it will be considered stale after 10 minutes, otherwise it is cached for 24 hours.
        */
       // Collect metadata
-      let keylessHeaders: Headers = new Headers();
-      try {
-        const metadata = await collectKeylessMetadata();
-        keylessHeaders = formatMetadataHeaders(metadata);
-      } catch {
-        // noop
-      }
+      const keylessHeaders = await collectKeylessMetadata()
+        .then(formatMetadataHeaders)
+        .catch(() => new Headers());
 
       await clerkDevelopmentCache?.run(
-        () => client.__experimental_accountlessApplications.completeAccountlessApplicationOnboarding(keylessHeaders),
+        () =>
+          client.__experimental_accountlessApplications.completeAccountlessApplicationOnboarding({
+            requestHeaders: keylessHeaders,
+          }),
         {
           cacheKey: `${newOrReadKeys.publishableKey}_complete`,
           onSuccessStale: 24 * 60 * 60 * 1000, // 24 hours

packages/nextjs/src/server/keyless-custom-headers.ts

@@ -26,7 +26,7 @@ export async function collectKeylessMetadata(): Promise<MetadataHeaders> {
  */
 function getNextVersion(): string | undefined {
   try {
-    return process.title; // 'next-server (v15.4.5)'
+    return process.title ?? 'unknown-process-title'; // 'next-server (v15.4.5)'
   } catch {
     return undefined;
   }

packages/nextjs/src/server/keyless-node.ts

@@ -137,16 +137,12 @@ async function createOrReadKeyless(): Promise<AccountlessApplication | null> {
   const client = createClerkClientWithOptions({});
 
   // Collect metadata
-  let keylessHeaders: Headers = new Headers();
-  try {
-    const metadata = await collectKeylessMetadata();
-    keylessHeaders = formatMetadataHeaders(metadata);
-  } catch {
-    // Continue with empty headers if metadata header collection fails
-  }
+  const keylessHeaders = await collectKeylessMetadata()
+    .then(formatMetadataHeaders)
+    .catch(() => new Headers());
 
   const accountlessApplication = await client.__experimental_accountlessApplications
-    .createAccountlessApplication(keylessHeaders)
+    .createAccountlessApplication({ requestHeaders: keylessHeaders })
     .catch(() => null);
 
   if (accountlessApplication) {