Fix parsing of friend simple-type-specifier #681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails to parse with an
Unexpected token 'EOF'.In
group,friend, not followed byclass/struct/union, is assumed to be a C++11 friendship declaration with a simple-type-specifier.boolis skipped, probably taken for some attributes, and a call totypeonoperator <throws the exception because it looks for template arguments until end of file.This PR proposes a fix by never skipping the token after
friend, sotypewill parse what is expected to be a type (boolin this case, instead ofoperator). I think that what needs to be skipped (attributes ?) only concerns non-friend declaration.No changes in parsing for existing presets, but in Pytorch, where an addition declaration (
ptr_to_first_element) is added inglobal.java. Without the PR, parsing ofList.hends prematurely because of afriend bool operator<.Allows to parse
intrusive_ptr.hin Pytorch.