Skip to content

Conversation

@omnibrian
Copy link

@omnibrian omnibrian commented Jul 21, 2025

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Update list of supported EKS platform versions to remove versions that are no longer receiving extended support (1.25, 1.26, and 1.27) and add new available versions.

Fixes #7373

New/Edited policies (Delete if not relevant)

  • CKV_AWS_339

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

@omnibrian
Copy link
Author

omnibrian commented Jul 21, 2025

Looking at the open PRs, I do see one that is trying to add 1.33 to the EKS platform versions already but is over a month old. Let me know if you'd rather just include that and I can close this PR.

Edit: Looks like adding 1.33 has been merged into main, edited to just be removing the older unsupported versions of EKS

@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from 44beb63 to bc8948c Compare July 22, 2025 13:16
@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from bc8948c to 15032b7 Compare July 23, 2025 14:03
@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from 15032b7 to bbd3db3 Compare July 28, 2025 13:51
Copy link
Contributor

@bo156 bo156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! :)

@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from bbd3db3 to 3cb1686 Compare August 7, 2025 14:52
@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from 3cb1686 to ac9e9b4 Compare August 7, 2025 15:16
@omnibrian
Copy link
Author

It looks like 1.27 has been dropped for extended support now too, included that removal in the change set

@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from ac9e9b4 to bcd7770 Compare August 12, 2025 14:26
@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from bcd7770 to a1d2760 Compare August 18, 2025 15:06
@MaryArmaly
Copy link
Contributor

Hey @omnibrian,
Could you please fix the failing tests? Thanks for the contribution!

@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from a1d2760 to 409d20e Compare August 20, 2025 14:23
@omnibrian
Copy link
Author

Hey @MaryArmaly, I wasn't able to reproduce the issue locally and the test doesn't seem to have any relation to the EKSPlatformVersion files I've touched. I just rebased changes against the latest in main in case it was an issue based on the point in time of main my changes were based on

@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from 409d20e to 18e41de Compare November 24, 2025 18:22
Update list of supported EKS platform versions to include new versions
and remove versions that are no longer receiving extended support.
@omnibrian omnibrian force-pushed the fix-terraform-eksplatformversion branch from 18e41de to 4505ddf Compare November 24, 2025 18:23
@omnibrian
Copy link
Author

Adding 1.34 since that's now been released as an EKS platform version. Also rebased on the latest in main.

I'm not sure if there's something in here that's stopping a review from happening, but it feels like this might be slipping through the cracks. @MaryArmaly or @bo156 or @achiar99 do any of you know if there's something I'm missing or someone I should reach out to?

I tried logging into the slack linked in README.md since CONTRIBUTING.md mentions asking for help in the slack but it looks like there's no way to sign up as an external contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CKV_AWS_339 - Update supported EKS versions

4 participants