Split SAMPLE_REQUEST_HEADERS and SAMPLE_RESPONSE_HEADERS to be more realistic

Author: misdoro

spec/acceptance/shared/request_expectations.rb

@@ -536,9 +536,9 @@
       describe "when request with headers is expected" do
         it "should satisfy expectation if request was executed with the same headers" do
           expect {
-            http_request(:get, "http://www.example.com/", headers: SAMPLE_HEADERS)
+            http_request(:get, "http://www.example.com/", headers: SAMPLE_REQUEST_HEADERS)
             expect(a_request(:get, "www.example.com").
-            with(headers: SAMPLE_HEADERS)).to have_been_made
+            with(headers: SAMPLE_REQUEST_HEADERS)).to have_been_made
           }.not_to raise_error
         end
 
@@ -578,7 +578,7 @@
 
         it "should fail if request was executed with different headers" do
           expect {
-            http_request(:get, "http://www.example.com/", headers: SAMPLE_HEADERS)
+            http_request(:get, "http://www.example.com/", headers: SAMPLE_REQUEST_HEADERS)
             expect(a_request(:get, "www.example.com").
             with(headers: { 'Content-Length' => '9999'})).to have_been_made
           }.to fail_with(%r(The request GET http://www.example.com/ with headers \{'Content-Length'=>'9999'\} was expected to execute 1 time but it executed 0 times))
@@ -606,7 +606,7 @@
           expect {
             http_request(:post, "http://www.example.com/",
                          body: "abc",
-                         headers: SAMPLE_HEADERS
+                         headers: SAMPLE_REQUEST_HEADERS
                          )
             expect(a_request(:post, "www.example.com")).to have_been_made
           }.not_to raise_error

spec/acceptance/shared/returning_declared_responses.rb

@@ -62,9 +62,9 @@ def call(request)
     end
 
     it "should return response with declared headers" do
-      stub_request(:get, "www.example.com").to_return(headers: SAMPLE_HEADERS)
+      stub_request(:get, "www.example.com").to_return(headers: SAMPLE_RESPONSE_HEADERS)
       response = http_request(:get, "http://www.example.com/")
-      expect(response.headers["Accept"]).to eq("application/json")
+      expect(response.headers["Content-Type"]).to eq("application/json")
       unless adapter_info.include?(:no_content_length_header)
         expect(response.headers["Content-Length"]).to eq("8888")
       end

spec/acceptance/shared/stubbing_requests.rb

@@ -366,10 +366,10 @@
 
     describe "based on headers" do
       it "should match requests if headers are the same" do
-        stub_request(:get, "www.example.com").with(headers: { "Accept" => "application/json" } )
+        stub_request(:get, "www.example.com").with(headers: SAMPLE_REQUEST_HEADERS )
         expect(http_request(
           :get, "http://www.example.com/",
-        headers: { "Accept" => "application/json" }).status).to eq("200")
+        headers: SAMPLE_REQUEST_HEADERS).status).to eq("200")
       end
 
       it "should match requests if headers are the same and declared as array" do
@@ -409,7 +409,7 @@
         stub_request(:get, "www.example.com")
         expect(http_request(
           :get, "http://www.example.com/",
-        headers: SAMPLE_HEADERS).status).to eq("200")
+        headers: SAMPLE_REQUEST_HEADERS).status).to eq("200")
       end
 
       it "should not match requests if headers are different" do

spec/acceptance/webmock_shared.rb

@@ -8,8 +8,9 @@
 require 'acceptance/shared/precedence_of_stubs'
 require 'acceptance/shared/complex_cross_concern_behaviors'
 
-unless defined? SAMPLE_HEADERS
-  SAMPLE_HEADERS = { "Accept" => "application/json" }
+unless defined? SAMPLE_REQUEST_HEADERS
+  SAMPLE_REQUEST_HEADERS = { "Accept" => "application/json" }
+  SAMPLE_RESPONSE_HEADERS = { "Content-Type" => "application/json", "Content-Length" => "8888" }
   ESCAPED_PARAMS = "x=ab%20c&z=%27Stop%21%27%20said%20Fred%20m"
   NOT_ESCAPED_PARAMS = "z='Stop!' said Fred m&x=ab c"
 end