feat(webkit): switch contrast, concentric radius & theme-stable handle - #799
Merged
Conversation
robsongajunior
previously approved these changes
Jul 26, 2026
robsongajunior
enabled auto-merge (squash)
July 26, 2026 01:49
herbert-julio-azion
previously approved these changes
Jul 27, 2026
robsongajunior
disabled auto-merge
July 27, 2026 18:21
isaquebock
previously approved these changes
Jul 27, 2026
The Switch redesign (concentric radius via --shape-elements / --radius, --accent checked track, theme-stable white handle with a black lock icon) intentionally changes pixels, so 34 baselines across Switch, FieldSwitch, FieldSwitchBlock and FieldTextSwitch no longer matched. Regenerated on ubuntu-latest via the Storybook Regenerate Baseline workflow (run 30360280255, full 6-mode matrix: 34 updated, 1868 unchanged) and taken from the visual-baselines-linux artifact — never generated on macOS, since linux/ is the CI contract.
gabriel-lisboa-azion
dismissed stale reviews from isaquebock, robsongajunior, and herbert-julio-azion
via
July 28, 2026 12:52
96fc55a
robsongajunior
approved these changes
Jul 28, 2026
rafaelgarbinatto
approved these changes
Jul 28, 2026
isaquebock
added a commit
that referenced
this pull request
Jul 28, 2026
The input now stretches to the wrapper height (h-full/self-stretch), which shifts the text line box by a sub-pixel amount in InputText and in FieldText, which composes it. Visually identical, but 56 snapshots no longer match. Regenerated on ubuntu-latest via the Storybook Regenerate Baseline workflow (run 30384502790, full matrix) and taken from the visual-baselines-linux artifact — linux/ is the CI contract, never generated on macOS. Only the snapshots CI reported as failing were taken; Switch baselines in the same artifact predate #799 and were deliberately left untouched.
robsongajunior
added a commit
that referenced
this pull request
Jul 28, 2026
* fix: [InputText] extend clickable area (ENG-46736) * fix: extend InputText clickable area to full field (ENG-46736) Add h-full + self-stretch to the inner <input> so it fills the wrapper vertically. Before this fix the input was auto-sized while the <span> wrapper set the row height, leaving a dead band above and below the placeholder line where clicks hit the wrapper without focusing the field. Refs: ENG-46736 * test: drop ENG-46736 tag and inline comments from clickable area block * fix: [ENG-46736] focus the InputText field from padding and icon areas * fix: [ENG-46736] restore the InputText vertical stretch lost in the main merge * refactor: [ENG-46736] drop redundant comments from InputText focus delegation * test: [ENG-46736] regenerate InputText and FieldText visual baselines The input now stretches to the wrapper height (h-full/self-stretch), which shifts the text line box by a sub-pixel amount in InputText and in FieldText, which composes it. Visually identical, but 56 snapshots no longer match. Regenerated on ubuntu-latest via the Storybook Regenerate Baseline workflow (run 30384502790, full matrix) and taken from the visual-baselines-linux artifact — linux/ is the CI contract, never generated on macOS. Only the snapshots CI reported as failing were taken; Switch baselines in the same artifact predate #799 and were deliberately left untouched. * test: [ENG-46736] regenerate LogView mobile visual baselines LogViewHeader embeds InputText for the "Find in Logs" field, so the same sub-pixel line-box shift reaches LogView; in the mobile modes it crosses the 1% threshold. Same artifact as the InputText/FieldText baselines (run 30384502790, ubuntu-latest). --------- Co-authored-by: ROBSON.JUNIOR <robsongajunior@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design enhancements to the
Switchcomponent (inputs/switch), addressing a dark-mode contrast bug and aligning shape with the token system.--bg-canvasand the lock icon--accent-contrast; in dark mode both resolved to black, so the lock icon (and the knob itself) had no contrast. The checked handle now uses--color-base-whiteand the lock icon--color-base-black— theme-independent base primitives, so the white knob + black lock stay fixed and legible in both light and dark.--accent(was the stale--success-contrastgreen).rounded-[var(--shape-elements)](6px); handle usesrounded-[var(--radius)](4px), concentric with the track (6px track −px-0.52px inset)..specs/switch.md): Tokens table + Theme gaps reflect the above; body checksum recomputed.Notes
--fg-handle-ontokens.validate-spec-compliance,validate-tokens, ESLint, andvue-tsctype-check all pass. Full Storybook build not run locally.