fix: [InputText] extend clickable area (ENG-46736) - #779
Merged
Conversation
Add h-full + self-stretch to the inner <input> so it fills the wrapper vertically. Before this fix the input was auto-sized while the <span> wrapper set the row height, leaving a dead band above and below the placeholder line where clicks hit the wrapper without focusing the field. Refs: ENG-46736
isaquebock
marked this pull request as ready for review
July 23, 2026 17:33
Contributor
As areas de padding laterais não estao dando focus quando o click acontece sobre elas
|
robsongajunior
previously approved these changes
Jul 28, 2026
The input now stretches to the wrapper height (h-full/self-stretch), which shifts the text line box by a sub-pixel amount in InputText and in FieldText, which composes it. Visually identical, but 56 snapshots no longer match. Regenerated on ubuntu-latest via the Storybook Regenerate Baseline workflow (run 30384502790, full matrix) and taken from the visual-baselines-linux artifact — linux/ is the CI contract, never generated on macOS. Only the snapshots CI reported as failing were taken; Switch baselines in the same artifact predate #799 and were deliberately left untouched.
robsongajunior
previously approved these changes
Jul 28, 2026
LogViewHeader embeds InputText for the "Find in Logs" field, so the same sub-pixel line-box shift reaches LogView; in the mobile modes it crosses the 1% threshold. Same artifact as the InputText/FieldText baselines (run 30384502790, ubuntu-latest).
gdsantana
approved these changes
Jul 28, 2026
robsongajunior
approved these changes
Jul 28, 2026
gabriel-lisboa-azion
added a commit
that referenced
this pull request
Jul 29, 2026
Brings in #782 (Select/MultiSelect/FieldSelect refinements) and #779 (InputText clickable area). Both regenerated linux visual baselines, which collided with the baselines this branch regenerated for the typography token changes: 60 binary PNGs that git cannot auto-merge (32 inputtext, 24 fieldtext, 4 logview). Neither side is correct for the merged tree, since main's baselines predate the token changes and ours predate the component changes. All 60 are resolved to main's version as the more recent component truth, and the full 1909-baseline matrix is regenerated from this merged tree in the following commit, which is what makes the set consistent. No source conflicts; catalog.json auto-merged. main did not touch packages/theme, so the rem letter-spacing scale and its dist output carry over unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix para ENG-46736 — "Clique só ativa na linha do placeholder — usar base do FieldTextArea".
Aplicado
h-full self-stretchno<input>interno para que ocupe toda a altura do wrapper — mesmo padrão doFieldTextArea.How to test (mapeado 1:1 com ENG-46736)
Problema Jira: "Ao clicar em InputsText, o clique só ativa/foca quando é feito exatamente na linha do placeholder — a área clicável não cobre o campo inteiro."
Default.small,medium,large) — área clicável cobre o campo inteiro em cada size.FieldTextArea(o comportamento agora é equivalente).