BillingMode: PAY_PER_REQUEST default #696#705
Merged
keetonian merged 1 commit intoaws:developfrom Dec 7, 2018
Jacco:issue696
Merged
BillingMode: PAY_PER_REQUEST default #696#705keetonian merged 1 commit intoaws:developfrom Jacco:issue696
keetonian merged 1 commit intoaws:developfrom
Jacco:issue696
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #705 +/- ##
===========================================
- Coverage 94.17% 94.16% -0.01%
===========================================
Files 67 67
Lines 2676 2675 -1
Branches 477 477
===========================================
- Hits 2520 2519 -1
Misses 80 80
Partials 76 76
Continue to review full report at Codecov.
|
keetonian
approved these changes
Dec 7, 2018
jlhood
approved these changes
Dec 7, 2018
Contributor
jlhood
left a comment
There was a problem hiding this comment.
Looks great! Thanks so much for doing this.
|
Was this reverted? It is not in master anymore. |
metaskills
added a commit
to 757rb/hello-757rb-lambda
that referenced
this pull request
Jan 16, 2019
Allow Lambda to own a DynamoDB instance and use it for storing results of API queries to PLOS. Details to support this change include: * Added [Aws::Record](https://github.com/aws/aws-sdk-ruby-record) gem to the project. * Change API Gateway to use `/{resource+}` to slurp all path params. * Pass the `query` query parameter down to the `PlosSearch` object. * New `PlosSearchTable` DynamoDB PORO with simple schema & migration class methods. * Made `PlosSearch#search` find or create DynamoDB records. * Lazily create DynamoDB tables in development & test envs. * Added an `Policies` section to the template.yml with full access to the new `PlosSearchTable` arn. Some helpful DynamoDB resources when getting started with SAM & Ruby. * [AWS::Serverless::SimpleTable in AWS SAM](https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#awsserverlesssimpletable) * [AWS::DynamoDB::Table in CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html) * [Amazon DynamoDB–related content from AWS re:Invent 2018](https://aws.amazon.com/blogs/database/amazon-dynamodb-related-content-from-aws-reinvent-2018/) * [The Aws::Record Gem](https://github.com/aws/aws-sdk-ruby-record) * [Announcing Amazon DynamoDB On-Demand](https://aws.amazon.com/about-aws/whats-new/2018/11/announcing-amazon-dynamodb-on-demand/) * [Future SAM Billing Mode Issue](aws/serverless-application-model#705) Other smaller changes include: * Added a STAGE parameter to CloudFormation template and "prod" to deploy script. * Created a simple Myenv PORO to check current ENV stuff. * Renamed some logical resource id names in template.yml.
Contributor
|
This is still in the release branch for v1.10.0. I'm working on finishing and testing the Conditions feature before we release everything in that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue #696 *
Description of changes:
Made BillingMode: PAY_PER_REQUEST default for AWS::Serverless::SimpleTable
Adjusted 6 test cases (x3=18 for all regional tests)
Added the default to the documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.