Skip to content

fix(dynamodb): fix SID for grants on multi-account global tables#37057

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
LeeroyHannigan:lhnng-multi-gt
Feb 23, 2026
Merged

fix(dynamodb): fix SID for grants on multi-account global tables#37057
mergify[bot] merged 3 commits intoaws:mainfrom
LeeroyHannigan:lhnng-multi-gt

Conversation

@LeeroyHannigan
Copy link
Copy Markdown
Contributor

@LeeroyHannigan LeeroyHannigan commented Feb 23, 2026

SID's must conform to ASCII uppercase letters (A-Z), lowercase letters (a-z), and numbers (0-9)

❌ The following Statement Ids are invalid: AllowMultiAccountReplicaAssociation-490940935144, (Service: DynamoDb, Status Code: 400, Request ID: ****) (SDK Attempt Count: 1)" (RequestToken: 7f8e0bfd-7b13-7b53-a5cf-10de2154de30, HandlerErrorCode: InvalidRequest)

Description of changes

The Sid element supports ASCII uppercase letters (A-Z), lowercase letters (a-z), and numbers (0-9).

Changed the SID in multiAccountReplicationTo in table-grants.ts to remove the -, which is forbidden.

Description of how you validated changes

Unit tests succeed

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…t conform to ASCII uppercase letters (A-Z), lowercase letters (a-z), and numbers (0-9)
@github-actions github-actions Bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Feb 23, 2026
@Abogical Abogical changed the title fix(dynamodb): fix SID for grants on multi-account global tables, mus… fix(dynamodb): fix SID for grants on multi-account global tables Feb 23, 2026
@Abogical Abogical self-assigned this Feb 23, 2026
@Abogical Abogical added p1 and removed p2 labels Feb 23, 2026
Copy link
Copy Markdown
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots needs to be updated.

@mergify mergify Bot dismissed Abogical’s stale review February 23, 2026 14:34

Pull request has been modified.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results24 ran24 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 23, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates24 ran24 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 23, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 23, 2026
@Abogical Abogical added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 23, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 23, 2026 15:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 23, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 23, 2026

Merge Queue Status

Rule: default-squash


  • Entered queue2026-02-23 15:47 UTC
  • Checks passed · in-place
  • Merged2026-02-23 16:19 UTC · at 1ae25da42bf1ac46b63405fb03c939520e69366f

This pull request spent 31 minutes 30 seconds in the queue, including 31 minutes 19 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 23, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 98d5e82 into aws:main Feb 23, 2026
22 of 23 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes valued-contributor [Pilot] contributed between 6-12 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants