dropped the network board address hack.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/node/board-discovery.ts

@@ -317,10 +317,10 @@ export class BoardDiscovery
           port,
         } as Board)
     );
-    return maybeEnhancePortAddress({
+    return {
       boards,
       port,
-    });
+    };
   }
 
   private fromRpcPort(rpcPort: RpcPort): Port {
@@ -369,48 +369,3 @@ namespace DetectedPort {
     return !!arg.port && arg.port.protocol === 'network' && !arg.boards.length;
   }
 }
-
-/**
- * Tries to enhance the port address if no boards were recognized for the port.
- * Basically, this method makes sure, that users will see more than an IP address
- * if the `'network'` board was not recognized by the Arduino CLI.
- *
- * See: https://github.com/arduino/arduino-ide/issues/1331
- */
-export function maybeEnhancePortAddress(
-  detectedPort: DetectedPort
-): DetectedPort {
-  for (const enhancer of PortAddressEnhancers) {
-    const enhanced = enhancer(detectedPort);
-    if (enhanced) {
-      return enhanced;
-    }
-  }
-  return detectedPort;
-}
-
-/**
- * Must return with `undefined` if the `arg` cannot be enhanced.
- */
-type PortAddressEnhancer = (arg: DetectedPort) => DetectedPort | undefined;
-const PortAddressEnhancers: PortAddressEnhancer[] = [enhanceESP32_S2];
-
-function enhanceESP32_S2(detectedPort: DetectedPort): DetectedPort | undefined {
-  if (DetectedPort.isUnrecognizedNetwork(detectedPort)) {
-    const { properties } = detectedPort.port;
-    if (properties) {
-      const board = properties['board']; // This is just a cheap hack. See https://github.com/arduino/arduino-ide/issues/567#issuecomment-1219494389
-      if (board) {
-        const { boards, port } = detectedPort;
-        return {
-          boards,
-          port: {
-            ...port,
-            address: `${board} at ${port.address}`,
-          },
-        };
-      }
-    }
-  }
-  return undefined;
-}