fix: sketchbook uri to path mapping

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/contributions/sketchbook.ts

@@ -14,18 +14,16 @@ import { OpenSketch } from './open-sketch';
 export class Sketchbook extends Examples {
   @inject(WindowServiceExt)
   private readonly windowService: WindowServiceExt;
+  private _currentSketchbookPath: string | undefined;
 
   override onStart(): void {
     this.sketchServiceClient.onSketchbookDidChange(() => this.update());
     this.configService.onDidChangeSketchDirUri(() => this.update());
     // If this window is changing the settings, and sketchbook location is included in the changeset,
     // then the users must be warned about the invalid sketches from the new sketchbook.
     this.settingsService.onWillChangeSoon(async (unsavedSettings) => {
-      const sketchbookUriBeforeChange = this.configService
-        .tryGetSketchDirUri()
-        ?.toString();
       // The sketchbook location is about to change.
-      if (unsavedSettings.sketchbookPath !== sketchbookUriBeforeChange) {
+      if (unsavedSettings.sketchbookPath !== this._currentSketchbookPath) {
         // Listen on both the settings and sketchbook location did change events
         const timeout = 5_000;
         const results = await Promise.allSettled([
@@ -41,6 +39,22 @@ export class Sketchbook extends Examples {
         }
       }
     });
+    const maybeUpdateCurrentSketchbookPath = async (
+      sketchDirUri: URI | undefined = this.configService.tryGetSketchDirUri()
+    ) => {
+      if (sketchDirUri) {
+        const candidateSketchbookPath = await this.fileService.fsPath(
+          sketchDirUri
+        );
+        if (candidateSketchbookPath !== this._currentSketchbookPath) {
+          this._currentSketchbookPath = candidateSketchbookPath;
+        }
+      }
+    };
+    this.configService.onDidChangeSketchDirUri(
+      maybeUpdateCurrentSketchbookPath
+    );
+    maybeUpdateCurrentSketchbookPath();
   }
 
   override async onReady(): Promise<void> {