fix: added profile URL, fixed menu label

From now on, the customized bottom widget hides the default setting menu

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -10,10 +10,7 @@ import {
   MenuContribution,
   MenuModelRegistry,
 } from '@theia/core';
-import {
-  FrontendApplication,
-  FrontendApplicationContribution,
-} from '@theia/core/lib/browser';
+import { FrontendApplicationContribution } from '@theia/core/lib/browser';
 import { ColorContribution } from '@theia/core/lib/browser/color-application-contribution';
 import { ColorRegistry } from '@theia/core/lib/browser/color-registry';
 import { CommonMenus } from '@theia/core/lib/browser/common-frontend-contribution';
@@ -77,7 +74,7 @@ export class ArduinoFrontendContribution
     }
   }
 
-  onStart(app: FrontendApplication): void {
+  onStart(): void {
     this.electronWindowPreferences.onPreferenceChanged((event) => {
       if (event.newValue !== event.oldValue) {
         switch (event.preferenceName) {
@@ -98,8 +95,6 @@ export class ArduinoFrontendContribution
         webContents.setZoomLevel(zoomLevel);
       })
     );
-    // Removes the _Settings_ (cog) icon from the left sidebar
-    app.shell.leftPanelHandler.removeBottomMenu('settings-menu');
   }
 
   registerToolbarItems(registry: TabBarToolbarRegistry): void {

arduino-ide-extension/src/browser/contributions/account.ts

@@ -55,7 +55,7 @@ export class Account extends Contribution {
       isEnabled: () => !Boolean(this.createFeatures.session),
     });
     registry.registerCommand(Account.Commands.GO_TO_PROFILE, {
-      execute: () => {},
+      execute: () => openExternal('https://id.arduino.cc/'),
       isEnabled: () => Boolean(this.createFeatures.session),
     });
     registry.registerCommand(Account.Commands.GO_TO_CLOUD_EDITOR, {
@@ -85,8 +85,7 @@ export class Account extends Contribution {
 
     register(ArduinoMenus.ARDUINO_ACCOUNT__CONTEXT__SIGN_IN_GROUP, [
       CloudUserCommands.LOGIN,
-      // TODO: why not 'Sign in to Arduino Cloud' like the current message in the cloud sketchbook tree?
-      nls.localize('arduino/account/signIn', 'Sign in with Arduino Cloud'),
+      nls.localize('arduino/cloud/signInToCloud', 'Sign in to Arduino Cloud'),
     ]);
     register(ArduinoMenus.ARDUINO_ACCOUNT__CONTEXT__LEARN_MORE_GROUP, [
       Account.Commands.LEARN_MORE,
@@ -139,9 +138,8 @@ export namespace Account {
     export const GO_TO_IOT_CLOUD: Command = {
       id: 'arduino-go-to-iot-cloud',
     };
-    export const LEARN_MORE: Command & { label: string } = {
+    export const LEARN_MORE: Command = {
       id: 'arduino-learn-more',
-      label: nls.localize('arduino/cloud/learnMore', 'Learn more'),
     };
   }
 }

arduino-ide-extension/src/browser/theia/core/sidebar-bottom-menu-widget.tsx

@@ -48,7 +48,11 @@ export class SidebarBottomMenuWidget extends TheiaSidebarBottomMenuWidget {
     );
   }
 
-  private renderMenu(menu: SidebarMenu): JSX.Element {
+  private renderMenu(menu: SidebarMenu): React.ReactNode {
+    // Removes the _Settings_ (cog) icon from the left sidebar
+    if (menu.id === 'settings-menu') {
+      return undefined;
+    }
     const arduinoAccount = menu.id === accountMenu.id;
     const picture =
       arduinoAccount && this.createFeatures.session?.account.picture;

i18n/en.json

@@ -8,8 +8,7 @@
       "goToCloudEditor": "Go to Cloud Editor",
       "goToIoTCloud": "Go to IoT Cloud",
       "goToProfile": "Go to Profile",
-      "menuTitle": "Arduino Cloud",
-      "signIn": "Sign in with Arduino Cloud"
+      "menuTitle": "Arduino Cloud"
     },
     "board": {
       "board": "Board{0}",