Removed useless state variable 'BuildCore'

Author: cmaglie

legacy/builder/setup_build_properties.go

@@ -49,7 +49,6 @@ func (s *SetupBuildProperties) Run(ctx *types.Context) error {
 		exPath = filepath.Dir(ex)
 	}
 
-	buildProperties.Set("build.core", ctx.BuildCore)
 	buildProperties.Set("runtime.ide.version", ctx.ArduinoAPIVersion)
 	buildProperties.Set("runtime.ide.path", exPath)
 	buildProperties.Set("ide_version", ctx.ArduinoAPIVersion)

legacy/builder/target_board_resolver.go

@@ -30,14 +30,13 @@ func (s *TargetBoardResolver) Run(ctx *types.Context) error {
 		return fmt.Errorf("%s: %w", tr("Error resolving FQBN"), err)
 	}
 
-	core := buildProperties.Get("build.core")
-	if core == "" {
-		core = "arduino"
-	}
-	// select the core name in case of "package:core" format
-	core = core[strings.Index(core, ":")+1:]
-
 	if ctx.Verbose {
+		core := buildProperties.Get("build.core")
+		if core == "" {
+			core = "arduino"
+		}
+		// select the core name in case of "package:core" format
+		core = core[strings.Index(core, ":")+1:]
 		ctx.Info(tr("Using board '%[1]s' from platform in folder: %[2]s", targetBoard.BoardID, targetPlatform.InstallDir))
 		ctx.Info(tr("Using core '%[1]s' from platform in folder: %[2]s", core, buildPlatform.InstallDir))
 	}
@@ -55,7 +54,6 @@ func (s *TargetBoardResolver) Run(ctx *types.Context) error {
 		return err
 	}
 
-	ctx.BuildCore = core
 	ctx.TargetBoard = targetBoard
 	ctx.TargetBoardBuildProperties = buildProperties
 	ctx.TargetPlatform = targetPlatform

legacy/builder/test/target_board_resolver_test.go

@@ -180,7 +180,7 @@ func TestTargetBoardResolverCustomCore(t *testing.T) {
 	require.Equal(t, "avr", targetPlatform.Platform.Architecture)
 	targetBoard := ctx.TargetBoard
 	require.Equal(t, "attiny841", targetBoard.BoardID)
-	require.Equal(t, "tiny841", ctx.BuildCore)
+	require.Equal(t, "tiny841", ctx.TargetBoardBuildProperties.Get("build.core"))
 	targetBoardBuildProperties := ctx.TargetBoardBuildProperties
 	require.Equal(t, "tiny14", targetBoardBuildProperties.Get("build.variant"))
 }

legacy/builder/types/context.go

@@ -95,7 +95,6 @@ type Context struct {
 	HardwareRewriteResults map[*cores.PlatformRelease][]PlatforKeyRewrite
 
 	BuildProperties              *properties.Map
-	BuildCore                    string
 	BuildPath                    *paths.Path
 	SketchBuildPath              *paths.Path
 	CoreBuildPath                *paths.Path