Migrate TestUploadSketchWithMismatchedCasing from test_upload.py to upload_test.go

Author: MatteoPologruto

internal/integrationtest/upload/upload_test.go

@@ -492,3 +492,36 @@ func TestCompileAndUploadComboSketchWithMismatchedCasing(t *testing.T) {
 		require.Contains(t, string(stderr), "Error opening sketch:")
 	}
 }
+
+func TestUploadSketchWithMismatchedCasing(t *testing.T) {
+	if os.Getenv("CI") != "" {
+		t.Skip("VMs have no serial ports")
+	}
+
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Create a sketch
+	sketchName := "UploadMismatchCasing"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Rename main .ino file so casing is different from sketch name
+	require.NoError(t, sketchPath.Join(sketchName+".ino").Rename(sketchPath.Join(strings.ToLower(sketchName)+".ino")))
+
+	for _, board := range detectedBoards(t, cli) {
+		// Install core
+		_, _, err = cli.Run("core", "install", board.core)
+		require.NoError(t, err)
+
+		// Tries to upload given sketch, it has not been compiled but it fails even before
+		// searching for binaries since the sketch is not valid
+		_, stderr, err := cli.Run("upload", "-b", board.fqbn, "-p", board.address, sketchPath.String())
+		require.Error(t, err)
+		require.Contains(t, string(stderr), "Error during Upload:")
+	}
+}

test/test_upload.py

@@ -42,29 +42,6 @@ def test_upload_after_attach(run_command, data_dir, detected_boards):
         assert run_command(["upload", sketch_path])
 
 
-def test_upload_sketch_with_mismatched_casing(run_command, data_dir, detected_boards, wait_for_board):
-    assert run_command(["update"])
-
-    # Create a sketch
-    sketch_name = "UploadMismatchCasing"
-    sketch_path = Path(data_dir, sketch_name)
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Rename main .ino file so casing is different from sketch name
-    Path(sketch_path, f"{sketch_name}.ino").rename(sketch_path / f"{sketch_name.lower()}.ino")
-
-    for board in detected_boards:
-        # Install core
-        core = ":".join(board.fqbn.split(":")[:2])
-        assert run_command(["core", "install", core])
-
-        # Tries to upload given sketch, it has not been compiled but it fails even before
-        # searching for binaries since the sketch is not valid
-        res = run_command(["upload", "-b", board.fqbn, "-p", board.address, sketch_path])
-        assert res.failed
-        assert "Error during Upload:" in res.stderr
-
-
 def test_upload_to_port_with_board_autodetect(run_command, data_dir, detected_boards):
     assert run_command(["update"])