Add Delete command to settings

Author: MatteoPologruto

commands/daemon/settings.go

@@ -24,6 +24,7 @@ import (
 
 	"github.com/arduino/arduino-cli/configuration"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/settings/v1"
+	"github.com/spf13/viper"
 )
 
 // SettingsService implements the `Settings` service
@@ -144,3 +145,38 @@ func (s *SettingsService) Write(ctx context.Context, req *rpc.WriteRequest) (*rp
 	}
 	return &rpc.WriteResponse{}, nil
 }
+
+// Delete removes a key from the config file
+func (s *SettingsService) Delete(ctx context.Context, req *rpc.DeleteRequest) (*rpc.DeleteResponse, error) {
+	toDelete := req.GetKey()
+
+	// Check if settings key actually existing, we don't use Viper.InConfig()
+	// since that doesn't check for keys formatted like daemon.port or those set
+	// with Viper.Set(). This way we check for all existing settings for sure.
+	keyExists := false
+	keys := []string{}
+	for _, k := range configuration.Settings.AllKeys() {
+		if !strings.HasPrefix(k, toDelete) {
+			keys = append(keys, k)
+			continue
+		}
+		keyExists = true
+	}
+
+	if !keyExists {
+		return nil, errors.New(tr("key not found in settings"))
+	}
+
+	updatedSettings := viper.New()
+	for _, k := range keys {
+		updatedSettings.Set(k, configuration.Settings.Get(k))
+	}
+
+	// Override current settings to delete the key
+	configuration.Settings = updatedSettings
+
+	if _, err := s.Write(ctx, &rpc.WriteRequest{FilePath: req.FilePath}); err != nil {
+		return nil, err
+	}
+	return &rpc.DeleteResponse{}, nil
+}