Fixing valgrind errors due to using temporare string as strcmp parameter

Author: aentinger

test/src/Stream/test_readBytes.cpp

@@ -21,22 +21,29 @@ TEST_CASE ("Testing readBytes(char *buffer, size_t length)", "[Stream-readBytes-
   WHEN ("the stream is empty")
   {
     char buf[32] = {0};
+
     REQUIRE(mock.readBytes(buf, sizeof(buf)) == 0);
   }
+
   WHEN ("the stream contains less data then we want to read")
   {
-    mock << "some stream content";
     char buf[32] = {0};
-    REQUIRE(mock.readBytes(buf, sizeof(buf)) == strlen("some stream content"));
-    REQUIRE(strcmp(buf, "some stream content") == 0);
+    char const str[] = "some stream content";
+    mock << str;
+
+    REQUIRE(mock.readBytes(buf, sizeof(buf)) == strlen(str));
+    REQUIRE(strncmp(buf, str, sizeof(buf)) == 0);
     REQUIRE(mock.readString() == arduino::String(""));
   }
-   WHEN ("the stream contains more data then we want to read")
+
+  WHEN ("the stream contains more data then we want to read")
   {
-    mock << "some stream content";
     char buf[5] = {0};
+    mock << "some stream content";
+    char const EXPECTED_STR[] = "some ";
+
     REQUIRE(mock.readBytes(buf, sizeof(buf)) == 5);
-    REQUIRE(strcmp(buf, "some ") == 0);
+    REQUIRE(strncmp(buf, EXPECTED_STR, sizeof(buf)) == 0);
     REQUIRE(mock.readString() == arduino::String("stream content"));
   }
 }