Add test case to invalidate & String::operator = (const String &rhs)

Author: giulcioffi

test/src/String/test_operators.cpp

@@ -116,26 +116,14 @@ TEST_CASE ("Testing & String::operator = (StringSumHelper &&rval)", "[String-ope
 
 TEST_CASE ("Testing & String::operator = (const String &)", "[String-operator+-13]")
 {
-  char *buffer1 = (char *)malloc(sizeof("Hello"));
-  strcpy(buffer1, "Hello");
-  arduino::String str1(buffer1);
+  arduino::String str1("Hello");
+
+  char *buffer2 = NULL;
 
-  char *buffer2 = (char *)malloc(sizeof("Hello"));
-  strcpy(buffer2, "Hello");
   arduino::String str2(buffer2);
 
-  //buffer2 = (char *)realloc(buffer, 0);
-  free(buffer2);
-  //arduino::String str1("Hello");
   str1 = str2;
-  REQUIRE(str1.compareTo("Hello") == 0);
-  free(buffer1);
-  /*
-  arduino::String str1;
-  char ch='!';
-  arduino::String str = (str1+ch);
-  REQUIRE(str.compareTo("Hello!") == 0);
-  */
+  REQUIRE(str1.compareTo(str2) == 0);
 }
 
 TEST_CASE ("Testing & String::operator = (const char *)", "[String-operator+-14]")