Skip to content

feat: add password personal data check #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christyjacob4 merged 11 commits into from
Aug 8, 2023
Merged

feat: add password personal data check #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6c9ae9a
feat: add password personal data check
christyjacob4 Apr 15, 2023
5f188c1
Merge branch 'main' of github.com:appwrite/console into disallow-pers…
christyjacob4 Apr 15, 2023
d77cc75
feat: add password personal data check
christyjacob4 Apr 15, 2023
4869b47
Merge branch 'main' of https://github.com/appwrite/console into disal…
christyjacob4 Jul 13, 2023
61ed63c
Merge branch 'main' of https://github.com/appwrite/console into disal…
christyjacob4 Jul 19, 2023
ab93a3f
chore: resovle review comments
christyjacob4 Jul 20, 2023
5df0999
chore: review comments
christyjacob4 Jul 20, 2023
78f50f8
feart: review comments
christyjacob4 Aug 8, 2023
b71c32e
feat: update to use new sdk
christyjacob4 Aug 8, 2023
adf9566
Merge branch '1.4.x' of https://github.com/appwrite/console into disa…
christyjacob4 Aug 8, 2023
4902198
chore: update dependencies
christyjacob4 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"dependencies": {
"@analytics/google-analytics": "^1.0.5",
"@appwrite.io/console": "0.2.0",
"@appwrite.io/console": "npm:christy-console@^0.3.0",
"@appwrite.io/pink": "^0.0.6-rc.10",
"@analytics/google-tag-manager": "^0.5.3",
"@popperjs/core": "^2.11.6",
Expand Down
1 change: 1 addition & 0 deletions src/lib/actions/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ export enum Submit {
AuthStatusUpdate = 'submit_auth_status_update',
AuthPasswordHistoryUpdate = 'submit_auth_password_history_limit_update',
AuthPasswordDictionaryUpdate = 'submit_auth_password_dictionary_update',
AuthPersonalDataCheckUpdate = 'submit_auth_personal_data_check_update',
SessionsLengthUpdate = 'submit_sessions_length_update',
SessionsLimitUpdate = 'submit_sessions_limit_update',
SessionDelete = 'submit_session_delete',
Expand Down
2 changes: 2 additions & 0 deletions src/routes/console/project-[project]/auth/security/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { Container } from '$lib/layout';
import UpdatePasswordDictionary from './updatePasswordDictionary.svelte';
import UpdatePasswordHistory from './updatePasswordHistory.svelte';
import UpdatePersonalDataCheck from './updatePersonalDataCheck.svelte';
import UpdateSessionLength from './updateSessionLength.svelte';
import UpdateSessionsLimit from './updateSessionsLimit.svelte';
import UpdateUsersLimit from './updateUsersLimit.svelte';
Expand All @@ -13,4 +14,5 @@
<UpdateSessionsLimit />
<UpdatePasswordHistory />
<UpdatePasswordDictionary />
<UpdatePersonalDataCheck />
</Container>
2 changes: 1 addition & 1 deletion src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<FormList>
<InputSwitch
bind:value={passwordHistoryEnabled}
id="passwordHisotryEnabled"
id="passwordHistoryEnabled"
label="Password History" />
</FormList>
<p class="text">
Expand Down
57 changes: 57 additions & 0 deletions src/routes/console/project-[project]/auth/security/updatePersonalDataCheck.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<script lang="ts">
import { invalidate } from '$app/navigation';
import { Submit, trackError, trackEvent } from '$lib/actions/analytics';
import { CardGrid, Heading } from '$lib/components';
import { Dependencies } from '$lib/constants';
import { Button, Form, InputSwitch } from '$lib/elements/forms';
import { FormList } from '$lib/elements/forms';
import { addNotification } from '$lib/stores/notifications';
import { sdk } from '$lib/stores/sdk';
import { project } from '../../store';

let authPersonalDataCheck = $project.authPersonalDataCheck ?? false;

async function updatePersonalDataCheck() {
try {
await sdk.forConsole.projects.updatePersonalDataCheck(
$project.$id,
authPersonalDataCheck
);
await invalidate(Dependencies.PROJECT);
addNotification({
type: 'success',
message: 'Toggled personal data checks for passwords'
});
trackEvent(Submit.AuthPersonalDataCheckUpdate);
} catch (error) {
addNotification({
type: 'error',
message: error.message
});
trackError(error, Submit.AuthPersonalDataCheckUpdate);
}
}
</script>

<Form onSubmit={updatePersonalDataCheck}>
<CardGrid>
<Heading tag="h2" size="7">Personal Data</Heading>
<svelte:fragment slot="aside">
<FormList>
<InputSwitch
bind:value={authPersonalDataCheck}
id="personalDataCheck"
label="Disallow Personal Data" />
</FormList>
<p class="text">
Do now allow passwords that contain any part of the user's personal data. This
includes the user's <code>name</code>, <code>email</code>, or <code>phone</code>.
</p>
</svelte:fragment>

<svelte:fragment slot="actions">
<Button disabled={authPersonalDataCheck === $project.authPersonalDataCheck} submit
>Update</Button>
</svelte:fragment>
</CardGrid>
</Form>