Qa callouts fixes #4

Author: balajisoundar

app/client/src/widgets/TableWidgetV2/component/TableStyledWrappers.tsx

@@ -309,6 +309,8 @@ export const TableStyles = css<{
   isTextType?: boolean;
 }>``;
 
+export const CELL_WRAPPER_LINE_HEIGHT = 28;
+
 export const CellWrapper = styled.div<{
   isHidden?: boolean;
   isHyperLink?: boolean;
@@ -351,7 +353,7 @@ export const CellWrapper = styled.div<{
   padding: ${(props) =>
       props.compactMode ? TABLE_SIZES[props.compactMode].VERTICAL_PADDING : 0}px
     10px;
-  line-height: 28px;
+  line-height: ${CELL_WRAPPER_LINE_HEIGHT}px;
   .${Classes.POPOVER_WRAPPER}, > span > span > span,
   > div > span > span > span {
     width: 100%;

app/client/src/widgets/TableWidgetV2/component/cellComponents/InlineCellEditor.tsx

@@ -94,7 +94,7 @@ export function InlineCellEditor({
 }: InlineEditorPropsType) {
   const inputRef = useRef<HTMLTextAreaElement | HTMLInputElement>(null);
   const [cursorPos, setCursorPos] = useState(value.length);
-  const onFocusChange = useCallback((focus: boolean) => !focus && onSave(), [
+  const onFocusChange = useCallback((focus: boolean) => !focus && onSave, [
     onSave,
   ]);
 

app/client/src/widgets/TableWidgetV2/component/cellComponents/TextCell.tsx

@@ -7,6 +7,7 @@ import { InlineCellEditor } from "./InlineCellEditor";
 import { ColumnTypes } from "widgets/TableWidgetV2/constants";
 import { ALIGN_ITEMS, TABLE_SIZES, VerticalAlignment } from "../Constants";
 import { InputTypes } from "widgets/BaseInputWidget/constants";
+import { CELL_WRAPPER_LINE_HEIGHT } from "../TableStyledWrappers";
 
 const Container = styled.div<{
   isCellEditMode?: boolean;
@@ -78,6 +79,10 @@ const UnsavedChangesMarker = styled.div<{ accentColor: string }>`
   transform: rotateZ(45deg);
 `;
 
+const Content = styled.div`
+  display: inline;
+`;
+
 interface PropType extends RenderDefaultPropsType {
   onChange: (text: string) => void;
   onDiscard: () => void;
@@ -121,18 +126,13 @@ export function TextCell({
     [toggleCellEditMode, value],
   );
 
-  const isMultiline = useCallback(() => {
-    const rowHeight = TABLE_SIZES[compactMode].ROW_HEIGHT;
-
-    return (
-      !!contentRef.current?.offsetHeight &&
-      contentRef.current?.offsetHeight - rowHeight > 10
-    );
-  }, [contentRef.current, compactMode]);
-
   let editor;
 
   if (isCellEditMode) {
+    const isMultiline =
+      !!contentRef.current?.offsetHeight &&
+      contentRef.current?.offsetHeight / CELL_WRAPPER_LINE_HEIGHT > 1;
+
     editor = (
       <InlineCellEditor
         accentColor={accentColor}
@@ -143,7 +143,7 @@ export function TextCell({
             ? InputTypes.NUMBER
             : InputTypes.TEXT
         }
-        multiline={isMultiline()}
+        multiline={isMultiline}
         onChange={onChange}
         onDiscard={onDiscard}
         onSave={onSave}
@@ -164,7 +164,6 @@ export function TextCell({
         compactMode={compactMode}
         isCellEditMode={isCellEditMode}
         onDoubleClick={onEditHandler}
-        ref={contentRef}
       >
         {hasUnsavedChanged && (
           <UnsavedChangesMarker accentColor={accentColor} />
@@ -185,7 +184,7 @@ export function TextCell({
           title={!!value ? value.toString() : ""}
           verticalAlignment={verticalAlignment}
         >
-          {value}
+          <Content ref={contentRef}>{value}</Content>
         </StyledAutoToolTipComponent>
         {isCellEditable && (
           <StyledEditIcon

app/client/src/widgets/TableWidgetV2/widget/index.tsx

@@ -814,7 +814,7 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
 
   handleColumnSorting = (columnAccessor: string, isAsc: boolean) => {
     const columnId = this.getColumnIdByAlias(columnAccessor);
-    this.resetSelectedRowIndex();
+    this.resetSelectedRowIndex(true);
 
     let sortOrderProps;
 
@@ -1027,7 +1027,7 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
     }
   };
 
-  resetSelectedRowIndex = () => {
+  resetSelectedRowIndex = (skipDefault?: boolean) => {
     const {
       defaultSelectedRowIndex,
       defaultSelectedRowIndices,
@@ -1037,12 +1037,12 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {
     if (multiRowSelection) {
       this.props.updateWidgetMetaProperty(
         "selectedRowIndices",
-        defaultSelectedRowIndices,
+        skipDefault ? [] : defaultSelectedRowIndices,
       );
     } else {
       this.props.updateWidgetMetaProperty(
         "selectedRowIndex",
-        defaultSelectedRowIndex,
+        skipDefault ? -1 : defaultSelectedRowIndex,
       );
     }
   };

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/ColumnControl.ts

@@ -174,7 +174,7 @@ export default {
       dependencies: ["primaryColumns", "columnType"],
       label: "Cell Wrapping",
       helpText: "Allows content of the cell to be wrapped",
-      defaultValue: false,
+      defaultValue: true,
       controlType: "SWITCH",
       customJSControl: "COMPUTE_VALUE_V2",
       isJSConvertible: true,

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/Events.ts

@@ -13,7 +13,6 @@ export default {
           ColumnTypes.BUTTON,
           ColumnTypes.ICON_BUTTON,
           ColumnTypes.IMAGE,
-          ColumnTypes.MENU_BUTTON,
           ColumnTypes.EDIT_ACTIONS,
         ],
         true,
@@ -71,22 +70,6 @@ export default {
       isBindProperty: true,
       isTriggerProperty: true,
     },
-    //MenuButton onClick
-    {
-      helpText: "Triggers an action when the menu item is clicked",
-      propertyName: "onClick",
-      label: "onItemClick",
-      controlType: "ACTION_SELECTOR",
-      isJSConvertible: true,
-      isBindProperty: true,
-      isTriggerProperty: true,
-      dependencies: ["primaryColumns", "columnOrder"],
-      hidden: (props: TableWidgetProps, propertyPath: string) => {
-        const baseProperty = getBasePropertyPath(propertyPath);
-        const columnType = get(props, `${baseProperty}.columnType`, "");
-        return columnType !== ColumnTypes.MENU_BUTTON;
-      },
-    },
     {
       propertyName: "onSubmit",
       label: "onSubmit",

app/client/src/widgets/TableWidgetV2/widget/propertyConfig/PanelConfig/MenuItems.ts

@@ -129,6 +129,21 @@ export default {
               },
             ],
           },
+          {
+            sectionName: "Events",
+            children: [
+              {
+                helpText: "Triggers an action when the menu item is clicked",
+                propertyName: "onClick",
+                label: "onItemClick",
+                controlType: "ACTION_SELECTOR",
+                isJSConvertible: true,
+                isBindProperty: true,
+                isTriggerProperty: true,
+                dependencies: ["primaryColumns", "columnOrder"],
+              },
+            ],
+          },
         ],
       },
     },

app/client/src/widgets/TextWidget/widget/index.tsx

@@ -83,6 +83,7 @@ class TextWidget extends BaseWidget<TextWidgetProps, WidgetState> {
             propertyName: "disableLink",
             helpText: "Controls parsing text as Link",
             label: "Disable Link",
+            defaultValue: false,
             controlType: "SWITCH",
             isJSConvertible: true,
             isBindProperty: true,