refactor: improve image lookup error diagnostics and update call sites#1588
Open
Ronitsabhaya75 wants to merge 1 commit into
Open
refactor: improve image lookup error diagnostics and update call sites#1588Ronitsabhaya75 wants to merge 1 commit into
Ronitsabhaya75 wants to merge 1 commit into
Conversation
Co-authored-by: Renish Patel <renishpatel2482001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This change updates
ClientImage.get(names:containerSystemConfig:)to returnerrors: [(String, Error)]instead oferror: [String].Previously, when looking up or saving multiple images, failures only reported the raw reference names. By propagating the actual underlying Swift
Errorobjects along with the failed names, commands likesaveanddeletecan output precise, localized error descriptions (e.g., distinguishing an "image not found" error from other network or service failures).All internal callers (
ImageDelete,ImageInspect, andClientImage.save) have been updated to consume this rich diagnostic information.Testing
@Renish-patel thanks for helping me