Skip to content

refactor: improve image lookup error diagnostics and update call sites#1588

Open
Ronitsabhaya75 wants to merge 1 commit into
apple:mainfrom
Ronitsabhaya75:image-save
Open

refactor: improve image lookup error diagnostics and update call sites#1588
Ronitsabhaya75 wants to merge 1 commit into
apple:mainfrom
Ronitsabhaya75:image-save

Conversation

@Ronitsabhaya75

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

This change updates ClientImage.get(names:containerSystemConfig:) to return errors: [(String, Error)] instead of error: [String].

Previously, when looking up or saving multiple images, failures only reported the raw reference names. By propagating the actual underlying Swift Error objects along with the failed names, commands like save and delete can output precise, localized error descriptions (e.g., distinguishing an "image not found" error from other network or service failures).

All internal callers (ImageDelete, ImageInspect, and ClientImage.save) have been updated to consume this rich diagnostic information.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

@Renish-patel thanks for helping me

Co-authored-by: Renish Patel <renishpatel2482001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants