-
Notifications
You must be signed in to change notification settings - Fork 3
feat: async pagination support with meta-data for each page #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…c/core-lib-java into async-pagination-support # Conflicts: # src/test/java/apimatic/core/type/pagination/OffsetPaginationTest.java # src/test/java/apimatic/core/type/pagination/PagePaginationTest.java
This reverts commit fce74d6.
src/main/java/io/apimatic/core/types/pagination/PageWrapper.java
Outdated
Show resolved
Hide resolved
sufyankhanrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
above mentioned comments need your attention.
|
sufyankhanrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just adding an observation here. The page wrapper class needs to be immutable as good design approach recommends following immutability principles.



What
This PR adds:
Why
To support pagination in the background thread instead of blocking the main thread
Type of change
Select multiple if applicable.
Dependency Change
N/A
Breaking change
N/A
Testing
List the steps that were taken to test the changes
Checklist