Skip to content

Conversation

@asadali214
Copy link
Collaborator

What

This PR adds:

  • Async pagination functionality
  • Multiple pagination strategies handling
  • Adds unit tests to cover the above
  • Refactors code

Why

To support pagination in the background thread instead of blocking the main thread

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

N/A

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 requested a review from sufyankhanrao June 12, 2025 03:56
@asadali214 asadali214 self-assigned this Jun 12, 2025
Copy link
Collaborator

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above mentioned comments need your attention.

@asadali214 asadali214 requested a review from sufyankhanrao June 13, 2025 10:18
@sonarqubecloud
Copy link

Copy link
Collaborator

@sufyankhanrao sufyankhanrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just adding an observation here. The page wrapper class needs to be immutable as good design approach recommends following immutability principles.

@asadali214 asadali214 merged commit de5fb85 into main Jun 13, 2025
10 checks passed
@asadali214 asadali214 deleted the async-pagination-support branch June 13, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants