Skip to content

Add metrics for loop detection. #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randall merged 2 commits into from
Mar 31, 2022
Merged

Add metrics for loop detection. #8772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50ddc09
Add metrics for loop detection.
cmcfarlen Mar 29, 2022
99d8b77
Add docs
cmcfarlen Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/admin-guide/monitoring/statistics/core/http-connection.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,16 @@ HTTP Connection

Tracks the number of client requests that did not have a request sent to the origin server because the origin server was marked dead.

.. ts:stat:: global proxy.process.http.http_proxy_loop_detected integer
:type: counter

Counts the number of times a proxy loop was detected

.. ts:stat:: global proxy.process.http.http_proxy_mh_loop_detected integer
:type: counter

Counts the number of times a multi-hop proxy loop was detected

HTTP/2
------

Expand Down
6 changes: 6 additions & 0 deletions proxy/http/HttpConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,12 @@ register_stat_callbacks()
RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.http.extension_method_requests", RECD_COUNTER, RECP_PERSISTENT,
(int)http_extension_method_requests_stat, RecRawStatSyncCount);

RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.http.http_proxy_loop_detected", RECD_COUNTER, RECP_PERSISTENT,
(int)http_proxy_loop_detected_stat, RecRawStatSyncCount);

RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.http.http_proxy_mh_loop_detected", RECD_COUNTER, RECP_PERSISTENT,
(int)http_proxy_mh_loop_detected_stat, RecRawStatSyncCount);

RecRegisterRawStat(http_rsb, RECT_PROCESS, "proxy.process.http.broken_server_connections", RECD_COUNTER, RECP_PERSISTENT,
(int)http_broken_server_connections_stat, RecRawStatSyncCount);

Expand Down
2 changes: 2 additions & 0 deletions proxy/http/HttpConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ enum {
http_purge_requests_stat,
http_connect_requests_stat,
http_extension_method_requests_stat,
http_proxy_loop_detected_stat,
http_proxy_mh_loop_detected_stat,

http_completed_requests_stat,
http_broken_server_connections_stat,
Expand Down
2 changes: 2 additions & 0 deletions proxy/http/HttpTransact.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6711,6 +6711,7 @@ HttpTransact::will_this_request_self_loop(State *s)
break;
}
SET_VIA_STRING(VIA_ERROR_TYPE, VIA_ERROR_LOOP_DETECTED);
HTTP_INCREMENT_DYN_STAT(http_proxy_loop_detected_stat);
build_error_response(s, HTTP_STATUS_BAD_REQUEST, "Cycle Detected", "request#cycle_detected");
return true;
}
Expand Down Expand Up @@ -6744,6 +6745,7 @@ HttpTransact::will_this_request_self_loop(State *s)
if (count > max_proxy_cycles) {
TxnDebug("http_transact", "count = %d > max_proxy_cycles = %d : detected loop", count, max_proxy_cycles);
SET_VIA_STRING(VIA_ERROR_TYPE, VIA_ERROR_LOOP_DETECTED);
HTTP_INCREMENT_DYN_STAT(http_proxy_mh_loop_detected_stat);
build_error_response(s, HTTP_STATUS_BAD_REQUEST, "Multi-Hop Cycle Detected", "request#cycle_detected");
return true;
} else {
Expand Down