Skip to content

Commit a552b3b

Browse files
author
Zizhong Zhang
committed
Fix #7164 Chaning Warning to Debug and creating a stat for inserting duplicates to pending dns
1 parent c637048 commit a552b3b

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

iocore/hostdb/HostDB.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1587,7 +1587,8 @@ HostDBContinuation::set_check_pending_dns()
15871587
Queue<HostDBContinuation> &q = hostDB.pending_dns_for_hash(hash.hash);
15881588
this->setThreadAffinity(this_ethread());
15891589
if (q.in(this)) {
1590-
Warning("Skip the insertion of the same continuation to pending dns");
1590+
HOSTDB_INCREMENT_DYN_STAT(hostdb_insert_duplicate_to_pending_dns_stat);
1591+
Debug("hostdb", "Skip the insertion of the same continuation to pending dns");
15911592
return false;
15921593
}
15931594
HostDBContinuation *c = q.head;
@@ -2159,6 +2160,9 @@ ink_hostdb_init(ts::ModuleVersion v)
21592160
RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.re_dns_on_reload", RECD_INT, RECP_PERSISTENT,
21602161
(int)hostdb_re_dns_on_reload_stat, RecRawStatSyncSum);
21612162

2163+
RecRegisterRawStat(hostdb_rsb, RECT_PROCESS, "proxy.process.hostdb.insert_duplicate_to_pending_dns", RECD_INT, RECP_PERSISTENT,
2164+
(int)hostdb_insert_duplicate_to_pending_dns_stat, RecRawStatSyncSum);
2165+
21622166
ts_host_res_global_init();
21632167
}
21642168

iocore/hostdb/P_HostDBProcessor.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ enum HostDB_Stats {
140140
hostdb_ttl_stat, // D average TTL
141141
hostdb_ttl_expires_stat, // D == TTL Expires
142142
hostdb_re_dns_on_reload_stat,
143+
hostdb_insert_duplicate_to_pending_dns_stat,
143144
HostDB_Stat_Count
144145
};
145146

0 commit comments

Comments
 (0)