Send and receive Transport Parameters with BoringSSL API

Author: maskit

iocore/net/quic/QUICTLS.cc

@@ -99,12 +99,6 @@ QUICTLS::remote_transport_parameters()
   return this->_remote_transport_parameters;
 }
 
-void
-QUICTLS::set_local_transport_parameters(std::shared_ptr<const QUICTransportParameters> tp)
-{
-  this->_local_transport_parameters = tp;
-}
-
 void
 QUICTLS::set_remote_transport_parameters(std::shared_ptr<const QUICTransportParameters> tp)
 {

iocore/net/quic/QUICTLS_boringssl.cc

@@ -63,6 +63,18 @@ set_encryption_secrets(SSL *ssl, enum ssl_encryption_level_t level, const uint8_
   qtls->update_key_materials_for_read(ats_level, read_secret, secret_len);
   qtls->update_key_materials_for_write(ats_level, write_secret, secret_len);
 
+  if (ats_level == QUICEncryptionLevel::ONE_RTT) {
+    // FIXME Where should this be placed?
+    const uint8_t *tp_buf;
+    size_t tp_buf_len;
+    SSL_get_peer_quic_transport_params(ssl, &tp_buf, &tp_buf_len);
+    if (SSL_is_server(ssl)) {
+      qtls->set_remote_transport_parameters(std::make_shared<QUICTransportParametersInClientHello>(tp_buf, tp_buf_len));
+    } else {
+      qtls->set_remote_transport_parameters(std::make_shared<QUICTransportParametersInEncryptedExtensions>(tp_buf, tp_buf_len));
+    }
+  }
+
   return 1;
 }
 
@@ -151,9 +163,21 @@ QUICTLS::QUICTLS(QUICPacketProtectionKeyInfo &pp_key_info, SSL_CTX *ssl_ctx, Net
   }
 }
 
+void
+QUICTLS::set_local_transport_parameters(std::shared_ptr<const QUICTransportParameters> tp)
+{
+  this->_local_transport_parameters = tp;
+
+  uint8_t buf[UINT16_MAX];
+  uint16_t len;
+  this->_local_transport_parameters->store(buf, &len);
+  SSL_set_quic_transport_params(this->_ssl, buf, len);
+}
+
 int
 QUICTLS::_process_post_handshake_messages(QUICHandshakeMsgs *out, const QUICHandshakeMsgs *in)
 {
+  this->_pass_quic_data_to_ssl_impl(*in);
   return SSL_process_quic_post_handshake(this->_ssl);
 }
 

iocore/net/quic/QUICTLS_openssl.cc

@@ -264,6 +264,12 @@ QUICTLS::get_encryption_level(int msg_type)
   }
 }
 
+void
+QUICTLS::set_local_transport_parameters(std::shared_ptr<const QUICTransportParameters> tp)
+{
+  this->_local_transport_parameters = tp;
+}
+
 int
 QUICTLS::_process_post_handshake_messages(QUICHandshakeMsgs *out, const QUICHandshakeMsgs *in)
 {
@@ -276,14 +282,7 @@ QUICTLS::_process_post_handshake_messages(QUICHandshakeMsgs *out, const QUICHand
   SSL_set_msg_callback(this->_ssl, QUICTLS::_msg_cb);
   SSL_set_msg_callback_arg(this->_ssl, out);
 
-  // TODO: set BIO_METHOD which read from QUICHandshakeMsgs directly
-  BIO *rbio = BIO_new(BIO_s_mem());
-  // TODO: set dummy BIO_METHOD which do nothing
-  BIO *wbio = BIO_new(BIO_s_mem());
-  if (in != nullptr && in->offsets[4] != 0) {
-    BIO_write(rbio, in->buf, in->offsets[4]);
-  }
-  SSL_set_bio(this->_ssl, rbio, wbio);
+  this->_pass_quic_data_to_ssl_impl(*in);
 
   uint8_t data[2048];
   size_t l = 0;