From 09998a3ae028a6a48d7ddc81a6d7e36482f119a5 Mon Sep 17 00:00:00 2001 From: Yanbo Liang Date: Mon, 16 Nov 2015 18:06:32 +0800 Subject: [PATCH 1/2] SparkR should export predict --- R/pkg/R/generics.R | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/R/pkg/R/generics.R b/R/pkg/R/generics.R index 612e639f8ad99..3c48e7c5cb0d1 100644 --- a/R/pkg/R/generics.R +++ b/R/pkg/R/generics.R @@ -1054,6 +1054,10 @@ setGeneric("year", function(x) { standardGeneric("year") }) #' @export setGeneric("glm") +#' @rdname predict +#' @export +setGeneric("predict", function(object, newData) { standardGeneric("predict") }) + #' @rdname rbind #' @export setGeneric("rbind", signature = "...") From 3012bfd4f6836f17dea35ffbe28ade6bd6f0ed34 Mon Sep 17 00:00:00 2001 From: Yanbo Liang Date: Tue, 17 Nov 2015 22:41:24 +0800 Subject: [PATCH 2/2] keep the signature of predict to be same as that in R base --- R/pkg/R/generics.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/pkg/R/generics.R b/R/pkg/R/generics.R index 3c48e7c5cb0d1..afdeffc2abd83 100644 --- a/R/pkg/R/generics.R +++ b/R/pkg/R/generics.R @@ -1056,7 +1056,7 @@ setGeneric("glm") #' @rdname predict #' @export -setGeneric("predict", function(object, newData) { standardGeneric("predict") }) +setGeneric("predict", function(object, ...) { standardGeneric("predict") }) #' @rdname rbind #' @export