Skip to content

nuttx/timer: add arch_alarm tick interface#7033

Merged
xiaoxiang781216 merged 2 commits into
apache:masterfrom
zyfeier:arch_alarm
Oct 12, 2022
Merged

nuttx/timer: add arch_alarm tick interface#7033
xiaoxiang781216 merged 2 commits into
apache:masterfrom
zyfeier:arch_alarm

Conversation

@zyfeier
Copy link
Copy Markdown
Contributor

@zyfeier zyfeier commented Sep 7, 2022 •
edited
Loading

Summary

  1. Use tick count for sched timer expiration;
  2. Adjust arch_alarm to support tick;

Impact

NA

Testing

sabre-6quad:nsh

@zyfeier zyfeier force-pushed the arch_alarm branch 4 times, most recently from 858486b to 5d9f9ba Compare September 9, 2022 02:25
@acassis
Copy link
Copy Markdown
Contributor

acassis commented Sep 11, 2022

Hi @zyfeier please include more information about this PR, what was the main motivation and what are the benefits of using this new interface? Did it make the system more accurate for timer measuring?

@zyfeier
Copy link
Copy Markdown
Contributor Author

zyfeier commented Sep 13, 2022

Hi @zyfeier please include more information about this PR, what was the main motivation and what are the benefits of using this new interface? Did it make the system more accurate for timer measuring?

Hi, acassis. This PR is not ready for review, it's a temporary change. I'll add more information if it was ready.

@xiaoxiang781216 xiaoxiang781216 marked this pull request as ready for review October 10, 2022 11:41
@xiaoxiang781216
Copy link
Copy Markdown
Contributor

xiaoxiang781216 commented Oct 10, 2022

@acassis this patch is ready for review. The motivation of this patch is to remove tick<->timespec conversion in tickless mode to improve the performance. Of course, the old interface still keep, the user need enable SCHED_TICKLESS_TICK_ARGUMENT to get the benefit.

pkarashchenko
pkarashchenko reviewed Oct 11, 2022
View reviewed changes
Comment thread arch/arm/src/stm32/stm32_tickless.c Outdated
Comment thread arch/arm/src/stm32/stm32_tickless.c Outdated
Comment thread arch/arm/src/stm32f7/stm32_tickless.c Outdated
Comment thread arch/arm/src/stm32f7/stm32_tickless.c Outdated
Comment thread arch/arm/src/stm32h7/stm32_tickless.c Outdated
Comment thread include/nuttx/timers/oneshot.h Outdated
Comment thread include/nuttx/timers/oneshot.h Outdated
Comment thread include/nuttx/timers/oneshot.h Outdated
Comment thread include/nuttx/timers/oneshot.h Outdated
Comment thread include/nuttx/timers/oneshot.h Outdated
@masayuki2009
Copy link
Copy Markdown
Contributor

masayuki2009 commented Oct 11, 2022

@zyfeier
Please rebase this PR to the latest upstream master.

pkarashchenko
pkarashchenko approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change

Comment thread include/nuttx/clock.h Outdated
@xiaoxiang781216 xiaoxiang781216 merged commit fc9b5e1 into apache:master Oct 12, 2022
@zyfeier zyfeier deleted the arch_alarm branch October 13, 2022 02:04
@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@masayuki2009 masayuki2009 Awaiting requested review from masayuki2009

@acassis acassis Awaiting requested review from acassis

@pkarashchenko pkarashchenko Awaiting requested review from pkarashchenko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zyfeier @acassis @xiaoxiang781216 @masayuki2009 @pkarashchenko @jerpelea