Skip to content

signals: fix dependency issues when signals are all disabled#3333

Merged
Donny9 merged 1 commit into
apache:masterfrom
wangchdo:enable_disable_all_signals
Jan 19, 2026
Merged

signals: fix dependency issues when signals are all disabled#3333
Donny9 merged 1 commit into
apache:masterfrom
wangchdo:enable_disable_all_signals

Conversation

@wangchdo
Copy link
Copy Markdown
Contributor

@wangchdo wangchdo commented Jan 15, 2026

Fix build and runtime issues when signals all disabled.

Summary

This PR fixes dependency issues when signals are all disabled

Impact

Fix dependency issues when signals are all disabled, no impact to any existing functions

Testing

ostest passed on rv-virt:smp64

disable all signals

image

ostest passed log

NuttShell (NSH)
nsh> 
nsh> uname -a
NuttX 0.0.0 02cfe5cf75-dirty Jan 15 2026 16:37:47 risc-v rv-virt
nsh> 
nsh> ostest

(...)

smp_call_test: Test start
smp_call_test: Call cpu 0, nowait
smp_call_test: Call cpu 0, wait
smp_call_test: Call cpu 1, nowait
smp_call_test: Call cpu 1, wait
smp_call_test: Call cpu 2, nowait
smp_call_test: Call cpu 2, wait
smp_call_test: Call cpu 3, nowait
smp_call_test: Call cpu 3, wait
smp_call_test: Call cpu 4, nowait
smp_call_test: Call cpu 4, wait
smp_call_test: Call cpu 5, nowait
smp_call_test: Call cpu 5, wait
smp_call_test: Call cpu 6, nowait
smp_call_test: Call cpu 6, wait
smp_call_test: Call cpu 7, nowait
smp_call_test: Call cpu 7, wait
smp_call_test: Call multi cpu, nowait
smp_call_test: Call in interrupt, wait
smp_call_test: Call multi cpu, wait
smp_call_test: Test success

Final memory usage:
VARIABLE  BEFORE   AFTER
======== ======== ========
arena     1fc2d20  1fc2d20
ordblks         1        7
mxordblk  1fb7c78  1f709c0
uordblks     b0a8    16278
fordblks  1fb7c78  1facaa8
user_main: Exiting
ostest_main: Exiting with status 0
nsh>

@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from e1cf0b0 to 0625200 Compare January 15, 2026 12:11
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 0625200 to cf6a657 Compare January 16, 2026 00:58
@wangchdo wangchdo mentioned this pull request Jan 16, 2026
Merged
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
Comment thread testing/ostest/Makefile Outdated
Comment thread testing/ostest/CMakeLists.txt
Comment thread examples/ipforward/ipforward.c
Comment thread examples/usrsocktest/usrsocktest_wake_with_signal.c
Comment thread wireless/ieee802154/i8sak/i8sak_events.c
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from cf6a657 to e3804fa Compare January 16, 2026 02:02
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
Comment thread examples/ipforward/ipforward.c
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 2 times, most recently from af94348 to 0cc5a9a Compare January 16, 2026 04:04
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
Comment thread wireless/ieee802154/i8sak/i8sak_events.c Outdated
Comment thread wireless/ieee802154/i8sak/i8sak_events.c Outdated
Comment thread testing/ostest/mqueue.c Outdated
Comment thread wireless/ieee802154/i8sak/i8sak_events.c Outdated
Comment thread testing/ostest/mqueue.c
Comment thread system/sensortest/sensortest.c Outdated
Comment thread examples/usrsocktest/usrsocktest_wake_with_signal.c Outdated
Comment thread examples/usrsocktest/usrsocktest_wake_with_signal.c Outdated
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch 5 times, most recently from 66096e1 to 62f6066 Compare January 16, 2026 09:21
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 62f6066 to 8610764 Compare January 16, 2026 09:52
xiaoxiang781216
xiaoxiang781216 reviewed Jan 16, 2026
View reviewed changes
Comment thread canutils/candump/CMakeLists.txt Outdated
Comment thread canutils/candump/Make.defs Outdated
Comment thread examples/i2sloop/Make.defs Outdated
Comment thread testing/drivers/nand_sim/Make.defs Outdated
Comment thread testing/drivers/nand_sim/CMakeLists.txt Outdated
Comment thread system/sensortest/Make.defs Outdated
Comment thread examples/zerocross/Make.defs Outdated
Comment thread examples/zerocross/CMakeLists.txt Outdated
Comment thread examples/xedge_demo/Make.defs Outdated
Comment thread examples/oneshot/Make.defs Outdated
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 8610764 to f6bf01a Compare January 16, 2026 14:13
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from f6bf01a to 7f9a65d Compare January 18, 2026 14:00
@wangchdo
signals: fix build and runtime issues when signals all isabled
0b1eef6 
 Fix build and runtime issues when signals all disabled.

Signed-off-by: Chengdong Wang <wangchengdong@lixiang.com>
@wangchdo wangchdo force-pushed the enable_disable_all_signals branch from 7f9a65d to 0b1eef6 Compare January 18, 2026 14:16
@wangchdo wangchdo mentioned this pull request Jan 18, 2026
Merged
@Donny9 Donny9 merged commit d9afe2d into apache:master Jan 19, 2026
40 checks passed
@wangchdo wangchdo deleted the enable_disable_all_signals branch January 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@Donny9 Donny9 Donny9 approved these changes

Assignees

No one assigned

Labels

Area: CAN Area: Examples Area: NSH Area: System Area: Testing Area: Wireless Size: M Size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangchdo @xiaoxiang781216 @Donny9