-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Try parent 46 #11521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Try parent 46 #11521
Conversation
pom.xml
Outdated
| <exclude>**/*.odg</exclude> | ||
| <exclude>**/*.svg</exclude> | ||
| <exclude>.asf.yaml</exclude> | ||
| <exclude>.mvn/**</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mvn is part of the MAVEN-default excludes
You could use
<inputExcludeStds>
<exclude>ALL</exclude>
</inputExcludeStds>
or
<exclude>MAVEN</exclude>
iff you only want the MAVEN excludes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ottlinger - trying with <exclude>ALL</exclude> but looks like not override a default list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry, misunderstanding: ALL activates all possible exclusion lists.
If you only want specific ones, remove ALL and add an entry for each Standard exclusion config you would like to have (ALL was just an example in above comment).
Possible values are documented here:
https://creadur.apache.org/rat/apache-rat/standard_collections.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I have changed to MAVEN .... and have:
1647 [INFO] --- apache-rat:0.17:check (rat-check) @ maven ---
1832 [WARNING] Basedir is : /Users/slawomir.jaranowski/repos/apache/maven
1838 [INFO] Excluding patterns: Jenkinsfile, **/.gitattributes, src/test/resources*/**, src/test/projects/**, src/test/remote-repo/**, its/**, **/*.odg, **/*.svg, .asf.yaml, .jbang/**, src/main/appended-resources/licenses/EPL-1.0.txt, src/main/appended-resources/licenses/unrecognized-aopalliance-1.0.txt, src/main/appended-resources/licenses/unrecognized-javax.annotation-api-1.3.2.txt, .java-version, .repository/**, .maven/spy.log, dependency-reduced-pom.xml, .asf.yaml, api/**, impl/**, compat/**, apache-maven/**
1838 [INFO] Excluding MAVEN collection.
1838 [INFO] Excluding MAVEN collection.
1838 [INFO] Excluding ECLIPSE collection.
1838 [INFO] Excluding IDEA collection.
1838 [INFO] Processing exclude file from STANDARD_SCMS.
1838 [INFO] Excluding STANDARD_SCMS collection.
1871 [INFO] Excluding MISC collection.
1871 [INFO] Excluding HIDDEN_DIR collection.
so MAVEN is processed twice ... I still can not disable default list ....
3f53f66 to
44662b8
Compare
44662b8 to
5e097fd
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.