Skip to content

fix(deps): update dependency express to v4.20.0 [security]#41

Closed
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-express-vulnerability
Closed

fix(deps): update dependency express to v4.20.0 [security]#41
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-express-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.18.2 -> 4.20.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: serve-static@0.16.0
    • Remove link renderization in html while redirecting
  • deps: send@0.19.0
    • Remove link renderization in html while redirecting
  • deps: body-parser@0.6.0
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: path-to-regexp@0.1.10
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

v4.18.3

Compare Source

==========

  • Fix routing requests without method
  • deps: body-parser@1.20.2
    • Fix strict json error message on Node.js 19+
    • deps: content-type@~1.0.5
    • deps: raw-body@2.5.2

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot changed the title Update dependency express to v4.19.2 [SECURITY] Update dependency express to v4.19.2 [SECURITY] - autoclosed Jun 23, 2024
@renovate renovate Bot closed this Jun 23, 2024
@renovate renovate Bot deleted the renovate/npm-express-vulnerability branch June 23, 2024 21:28
@renovate renovate Bot changed the title Update dependency express to v4.19.2 [SECURITY] - autoclosed Update dependency express to v4.19.2 [SECURITY] Jun 24, 2024
@renovate renovate Bot restored the renovate/npm-express-vulnerability branch June 24, 2024 00:12
@renovate renovate Bot reopened this Jun 24, 2024
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from 29e3c24 to 7a70ce9 Compare June 24, 2024 00:13
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from 7a70ce9 to 09d42f7 Compare September 19, 2024 15:46
@renovate renovate Bot changed the title Update dependency express to v4.19.2 [SECURITY] Update dependency express to v4.20.0 [SECURITY] Sep 19, 2024
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from 09d42f7 to e8ff5e5 Compare January 23, 2025 17:55
@renovate renovate Bot changed the title Update dependency express to v4.20.0 [SECURITY] fix(deps): update dependency express to v4.20.0 [security] Jan 30, 2025
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from e8ff5e5 to 31c89ec Compare February 9, 2025 12:31
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from 31c89ec to 5dd5d87 Compare March 3, 2025 17:40
@renovate renovate Bot force-pushed the renovate/npm-express-vulnerability branch from 5dd5d87 to 36d5d46 Compare March 11, 2025 11:18
@jdaugherty jdaugherty closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant