Skip to content

Commit 4b994b0

Browse files
authored
[ISSUE #4021] Replace LinkedList by ArrayList (#4233)
* replace LinkedList by ArrayList * update import order
1 parent 14bf5c2 commit 4b994b0

5 files changed

Lines changed: 9 additions & 10 deletions

File tree

eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/Subscription.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@
1919

2020
import org.apache.eventmesh.common.protocol.SubscriptionItem;
2121

22-
import java.util.LinkedList;
22+
import java.util.ArrayList;
2323
import java.util.List;
2424

2525
public class Subscription {
2626

27-
private List<SubscriptionItem> topicList = new LinkedList<>();
27+
private List<SubscriptionItem> topicList = new ArrayList<>();
2828

2929
public Subscription() {
3030
}

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@
4141
import org.apache.http.impl.client.CloseableHttpClient;
4242
import org.apache.http.impl.client.HttpClients;
4343

44+
import java.util.ArrayList;
4445
import java.util.Iterator;
45-
import java.util.LinkedList;
4646
import java.util.List;
4747
import java.util.Optional;
4848
import java.util.concurrent.BlockingQueue;
@@ -276,7 +276,7 @@ private void initThreadPool() {
276276
}
277277

278278
private void initHttpClientPool() {
279-
httpClientPool = new LinkedList<>();
279+
httpClientPool = new ArrayList<>();
280280
int clientPool = RandomUtils.nextInt(MIN_LIMIT, MAX_LIMIT);
281281
for (int i = 0; i < clientPool; i++) {
282282
CloseableHttpClient client = HttpClients.createDefault();

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import java.util.Date;
3333
import java.util.HashSet;
3434
import java.util.Iterator;
35-
import java.util.LinkedList;
3635
import java.util.List;
3736
import java.util.Map;
3837
import java.util.Set;
@@ -210,7 +209,7 @@ private void startClientCheck() {
210209
log.debug("grpc client info check");
211210
}
212211

213-
final List<ConsumerGroupClient> clientList = new LinkedList<>();
212+
final List<ConsumerGroupClient> clientList = new ArrayList<>();
214213
clientTable.values().forEach(clients -> {
215214
clientList.addAll(clients);
216215
});

eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
import org.apache.commons.collections4.CollectionUtils;
3636

3737
import java.nio.charset.StandardCharsets;
38+
import java.util.ArrayList;
3839
import java.util.Collections;
39-
import java.util.LinkedList;
4040
import java.util.List;
4141
import java.util.concurrent.ConcurrentHashMap;
4242

@@ -56,7 +56,7 @@
5656
@Slf4j
5757
class CloudEventTCPSubClient extends TcpClient implements EventMeshTCPSubClient<CloudEvent> {
5858

59-
private final List<SubscriptionItem> subscriptionItems = Collections.synchronizedList(new LinkedList<>());
59+
private final List<SubscriptionItem> subscriptionItems = Collections.synchronizedList(new ArrayList<>());
6060
private ReceiveMsgHook<CloudEvent> callback;
6161

6262
public CloudEventTCPSubClient(EventMeshTCPClientConfig eventMeshTcpClientConfig) {

eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636

3737
import org.apache.commons.collections4.CollectionUtils;
3838

39+
import java.util.ArrayList;
3940
import java.util.Collections;
40-
import java.util.LinkedList;
4141
import java.util.List;
4242
import java.util.concurrent.ConcurrentHashMap;
4343

@@ -48,7 +48,7 @@
4848
@Slf4j
4949
class EventMeshMessageTCPSubClient extends TcpClient implements EventMeshTCPSubClient<EventMeshMessage> {
5050

51-
private final List<SubscriptionItem> subscriptionItems = Collections.synchronizedList(new LinkedList<>());
51+
private final List<SubscriptionItem> subscriptionItems = Collections.synchronizedList(new ArrayList<>());
5252
private ReceiveMsgHook<EventMeshMessage> callback;
5353

5454
public EventMeshMessageTCPSubClient(EventMeshTCPClientConfig eventMeshTcpClientConfig) {

0 commit comments

Comments
 (0)