From 056c253cac98a31790cd8dbcb6ef8f788071b7dd Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 20 Dec 2024 09:08:36 -0500 Subject: [PATCH 1/3] Minor: improve error message when ARRAY literals can not be planned --- datafusion/sql/src/expr/value.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/sql/src/expr/value.rs b/datafusion/sql/src/expr/value.rs index a70934b5cd5d9..354653e632053 100644 --- a/datafusion/sql/src/expr/value.rs +++ b/datafusion/sql/src/expr/value.rs @@ -24,7 +24,7 @@ use arrow_schema::{DataType, DECIMAL256_MAX_PRECISION}; use bigdecimal::num_bigint::BigInt; use bigdecimal::{BigDecimal, Signed, ToPrimitive}; use datafusion_common::{ - internal_datafusion_err, internal_err, not_impl_err, plan_err, DFSchema, + internal_datafusion_err, not_impl_err, plan_err, DFSchema, DataFusionError, Result, ScalarValue, }; use datafusion_expr::expr::{BinaryExpr, Placeholder}; @@ -169,7 +169,7 @@ impl SqlToRel<'_, S> { } } - internal_err!("Expected a simplified result, but none was found") + not_impl_err!("Could not plan array literal. Hint: is `nested_expressions` DataFusion feature selected?") } /// Convert a SQL interval expression to a DataFusion logical plan From 457fc5f05a8fd5b483e7770cc5c38b5cee212723 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 20 Dec 2024 09:08:45 -0500 Subject: [PATCH 2/3] fmt --- datafusion/sql/src/expr/value.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/sql/src/expr/value.rs b/datafusion/sql/src/expr/value.rs index 354653e632053..fdcbaa8ef86f9 100644 --- a/datafusion/sql/src/expr/value.rs +++ b/datafusion/sql/src/expr/value.rs @@ -24,8 +24,8 @@ use arrow_schema::{DataType, DECIMAL256_MAX_PRECISION}; use bigdecimal::num_bigint::BigInt; use bigdecimal::{BigDecimal, Signed, ToPrimitive}; use datafusion_common::{ - internal_datafusion_err, not_impl_err, plan_err, DFSchema, - DataFusionError, Result, ScalarValue, + internal_datafusion_err, not_impl_err, plan_err, DFSchema, DataFusionError, Result, + ScalarValue, }; use datafusion_expr::expr::{BinaryExpr, Placeholder}; use datafusion_expr::planner::PlannerResult; From 5bcb79488234b6b2aa08d4e9d027b603bef872bf Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 20 Dec 2024 21:05:25 -0500 Subject: [PATCH 3/3] Update datafusion/sql/src/expr/value.rs Co-authored-by: Oleks V --- datafusion/sql/src/expr/value.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/sql/src/expr/value.rs b/datafusion/sql/src/expr/value.rs index fdcbaa8ef86f9..847163c6d3b3e 100644 --- a/datafusion/sql/src/expr/value.rs +++ b/datafusion/sql/src/expr/value.rs @@ -169,7 +169,7 @@ impl SqlToRel<'_, S> { } } - not_impl_err!("Could not plan array literal. Hint: is `nested_expressions` DataFusion feature selected?") + not_impl_err!("Could not plan array literal. Hint: Please try with `nested_expressions` DataFusion feature enabled") } /// Convert a SQL interval expression to a DataFusion logical plan