revmoe redundant clone

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

Author: jayzhan211

datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs

@@ -395,13 +395,11 @@ impl<'a> ConstEvaluator<'a> {
                         "Could not evaluate the expression, found a result of length {}",
                         a.len()
                     )
+                } else if as_list_array(&a).is_ok() || as_large_list_array(&a).is_ok() {
+                    Ok(ScalarValue::ListArr(a))
                 } else {
-                    if as_list_array(&a).is_ok() || as_large_list_array(&a).is_ok() {
-                        Ok(ScalarValue::ListArr(a))
-                    } else {
-                        // Non-ListArray
-                        ScalarValue::try_from_array(&a, 0)
-                    }
+                    // Non-ListArray
+                    ScalarValue::try_from_array(&a, 0)
                 }
             }
             ColumnarValue::Scalar(s) => Ok(s),
@@ -3267,7 +3265,7 @@ mod tests {
         let expr_x = col("c3").gt(lit(3_i64));
         let expr_y = (col("c4") + lit(2_u32)).lt(lit(10_u32));
         let expr_z = col("c1").in_list(vec![lit("a"), lit("b")], true);
-        let expr = expr_x.clone().and(expr_y.clone().or(expr_z));
+        let expr = expr_x.clone().and(expr_y.or(expr_z));
 
         // All guaranteed null
         let guarantees = vec![
@@ -3342,7 +3340,7 @@ mod tests {
             col("c4"),
             NullableInterval::from(ScalarValue::UInt32(Some(3))),
         )];
-        let output = simplify_with_guarantee(expr.clone(), guarantees);
+        let output = simplify_with_guarantee(expr, guarantees);
         assert_eq!(&output, &expr_x);
     }
 }

datafusion/optimizer/src/simplify_expressions/guarantees.rs

@@ -216,12 +216,12 @@ mod tests {
 
         // x IS NULL => guaranteed false
         let expr = col("x").is_null();
-        let output = expr.clone().rewrite(&mut rewriter).unwrap();
+        let output = expr.rewrite(&mut rewriter).unwrap();
         assert_eq!(output, lit(false));
 
         // x IS NOT NULL => guaranteed true
         let expr = col("x").is_not_null();
-        let output = expr.clone().rewrite(&mut rewriter).unwrap();
+        let output = expr.rewrite(&mut rewriter).unwrap();
         assert_eq!(output, lit(true));
     }
 

datafusion/physical-expr/src/aggregate/count_distinct.rs

@@ -204,6 +204,7 @@ mod tests {
     };
     use arrow::datatypes::DataType;
     use datafusion_common::internal_err;
+    use datafusion_common::DataFusionError;
 
     macro_rules! state_to_vec {
         ($LIST:expr, $DATA_TYPE:ident, $PRIM_TY:ty) => {{

datafusion/physical-expr/src/aggregate/min_max.rs

@@ -1501,7 +1501,7 @@ mod tests {
             .with_data_type(dt.clone());
         let expected: ArrayRef =
             Arc::new(TimestampMicrosecondArray::from(vec![5]).with_data_type(dt.clone()));
-        generic_test_op_new!(Arc::new(actual), dt.clone(), Max, &expected)
+        generic_test_op_new!(Arc::new(actual), dt, Max, &expected)
     }
 
     #[test]
@@ -1511,7 +1511,7 @@ mod tests {
             .with_data_type(dt.clone());
         let expected: ArrayRef =
             Arc::new(TimestampMicrosecondArray::from(vec![5]).with_data_type(dt.clone()));
-        generic_test_op_new!(Arc::new(actual), dt.clone(), Max, &expected)
+        generic_test_op_new!(Arc::new(actual), dt, Max, &expected)
     }
 
     #[test]

datafusion/physical-expr/src/utils.rs

@@ -1803,7 +1803,7 @@ mod tests {
                 options: SortOptions::default(),
             }]),
             EquivalenceProperties::new(Arc::new(schema.clone())),
-            OrderingEquivalenceProperties::new(Arc::new(schema.clone())),
+            OrderingEquivalenceProperties::new(Arc::new(schema)),
         )?;
 
         assert_eq!(