Revert back the deprecation messages in the custom StringUtils class to favour the use of the ApacheUtils

Author: Dingane Hlaluku

plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

@@ -44,6 +44,7 @@
 import javax.naming.ConfigurationException;
 
 import org.apache.commons.lang.math.NumberUtils;
+import org.apache.commons.lang.StringUtils;
 import org.apache.log4j.Logger;
 import org.apache.log4j.NDC;
 import org.joda.time.Duration;
@@ -295,7 +296,6 @@
 import com.cloud.utils.ExecutionResult;
 import com.cloud.utils.NumbersUtil;
 import com.cloud.utils.Pair;
-import com.cloud.utils.StringUtils;
 import com.cloud.utils.Ternary;
 import com.cloud.utils.db.DB;
 import com.cloud.utils.exception.CloudRuntimeException;
@@ -4398,7 +4398,7 @@ private Answer execute(MigrateVolumeCommand cmd) {
         VmwareHypervisorHost srcHyperHost = null;
 
         // OfflineVmwareMigration: ifhost is null ???
-        if (StringUtils.isBlank(cmd.getAttachedVmName())) {
+        if (org.apache.commons.lang.StringUtils.isBlank(cmd.getAttachedVmName())) {
             return migrateVolume(cmd);
         }
         ManagedObjectReference morDs = null;

utils/src/main/java/com/cloud/utils/StringUtils.java

@@ -73,11 +73,20 @@ public static String join(final Iterable<? extends Object> iterable, final Strin
     public static String join(final String delimiter, final Object... components) {
         return org.apache.commons.lang.StringUtils.join(components, delimiter);
     }
-
+    /**
+     * @deprecated
+     * Please use org.apache.commons.lang.StringUtils.isBlank() as a replacement
+     */
+    @Deprecated
     public static boolean isBlank(String str) {
         return org.apache.commons.lang.StringUtils.isBlank(str);
     }
 
+    /**
+     * @deprecated
+     * Please use org.apache.commons.lang.StringUtils.isNotBlank() as a replacement
+     */
+    @Deprecated
     public static boolean isNotBlank(final String str) {
         return org.apache.commons.lang.StringUtils.isNotBlank(str);
     }