system_use column is now moved from disk_offering table to service_offering table, because it is applicable only to service offering.

harikrishna-patnala · harikrishna-patnala · commit 74a15a5c2369 · 2022-02-21T18:20:09.000+05:30
There is a left over usage of system_use when user tries to list disk offering. Now we deleted that reference.
diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
@@ -2932,10 +2932,7 @@ private Pair<List<DiskOfferingJoinVO>, Integer> searchForDiskOfferingsInternal(L
                 if (account.getType() == Account.ACCOUNT_TYPE_NORMAL) {
                     throw new InvalidParameterValueException("Only ROOT admins and Domain admins can list disk offerings with isrecursive=true");
                 }
-            } else { // domain + all ancestors
-                sc.addAnd("systemUse", SearchCriteria.Op.EQ, false); // non-root users should not see system offering at all
             }
-
         }
 
         if (volumeId != null && storagePoolId != null) {

Original file line number	Diff line number	Diff line change
`@@ -2932,10 +2932,7 @@ private Pair<List<DiskOfferingJoinVO>, Integer> searchForDiskOfferingsInternal(L`
`2932`	`2932`	`if (account.getType() == Account.ACCOUNT_TYPE_NORMAL) {`
`2933`	`2933`	`throw new InvalidParameterValueException("Only ROOT admins and Domain admins can list disk offerings with isrecursive=true");`
`2934`	`2934`	`}`
`2935`		`- } else { // domain + all ancestors`
`2936`		`- sc.addAnd("systemUse", SearchCriteria.Op.EQ, false); // non-root users should not see system offering at all`
`2937`	`2935`	`}`
`2938`		`-`
`2939`	`2936`	`}`
`2940`	`2937`
`2941`	`2938`	`if (volumeId != null && storagePoolId != null) {`