Skip to content

Commit dd0d8a1

Browse files
committed
fix link and warning
1 parent 72095eb commit dd0d8a1

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

cpp/src/arrow/compute/kernels/hash.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -287,13 +287,12 @@ class RegularHashKernelImpl : public HashKernelImpl {
287287
auto on_found = [this](int32_t memo_index) { action_.ObserveFound(memo_index); };
288288

289289
if (with_error_status) {
290-
291-
Status status;
290+
Status status;
292291
auto on_not_found = [this, &status](int32_t memo_index) {
293292
action_.ObserveNotFound(memo_index, &status);
294293
};
295294
memo_table_->GetOrInsert(value, on_found, on_not_found);
296-
return status;
295+
return status;
297296
} else {
298297
auto on_not_found = [this](int32_t memo_index) {
299298
action_.ObserveNotFound(memo_index);
@@ -381,7 +380,8 @@ struct HashKernelTraits<Type, Action, with_error_status, enable_if_binary<Type>>
381380
};
382381

383382
template <typename Type, typename Action, bool with_error_status>
384-
struct HashKernelTraits<Type, Action, with_error_status, enable_if_fixed_size_binary<Type>> {
383+
struct HashKernelTraits<Type, Action, with_error_status,
384+
enable_if_fixed_size_binary<Type>> {
385385
using HashKernelImpl =
386386
RegularHashKernelImpl<Type, util::string_view, Action, with_error_status>;
387387
};

cpp/src/arrow/util/hashing.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ class SmallScalarMemoTable {
475475
void CopyValues(int32_t start, Scalar* out_data) const {
476476
DCHECK_GE(start, 0);
477477
DCHECK_LE(static_cast<size_t>(start), index_to_value_.size());
478-
int offset = start * sizeof(Scalar);
478+
int32_t offset = start * static_cast<int32_t>(sizeof(Scalar));
479479
memcpy(out_data, index_to_value_.data() + offset, (size() - start) * sizeof(Scalar));
480480
}
481481

0 commit comments

Comments
 (0)