Skip to content

Commit ae1f98f

Browse files
authored
GH-34047: [C++][FlightRPC] Make DoAction warning less prominent (#34182)
### Rationale for this change The warning added for when you fail to consume a result stream (and get the final error/success result) is a bit aggressive. Ignore it in most cases. ### What changes are included in this PR? Drop the warning to DEBUG level and don't log if it's just a cancellation. ### Are these changes tested? Existing tests cover it. ### Are there any user-facing changes? Users should see less inactionable warnings. * Closes: #34047 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
1 parent 277bd3c commit ae1f98f

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

cpp/src/arrow/flight/transport/grpc/grpc_client.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,8 +510,12 @@ class GrpcResultStream : public ResultStream {
510510
~GrpcResultStream() override {
511511
if (stream_) {
512512
rpc_.context.TryCancel();
513-
ARROW_WARN_NOT_OK(FromGrpcStatus(stream_->Finish(), &rpc_.context),
514-
"DoAction result was not fully consumed");
513+
auto status = FromGrpcStatus(stream_->Finish(), &rpc_.context);
514+
if (!status.ok() && !status.IsCancelled()) {
515+
ARROW_LOG(DEBUG)
516+
<< "DoAction result was not fully consumed, server returned error: "
517+
<< status.ToString();
518+
}
515519
}
516520
}
517521

0 commit comments

Comments
 (0)