From 7cbc95ad079a478190852eb9555249530caa0c4d Mon Sep 17 00:00:00 2001 From: Daniel Standish <15932138+dstandish@users.noreply.github.com> Date: Wed, 11 Jan 2023 22:11:35 -0800 Subject: [PATCH] Add dep context description for better log message Otherwise, it appears that there is a duplicate log record. --- airflow/models/taskinstance.py | 4 +++- airflow/ti_deps/dep_context.py | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py index 36a0b5bf2b2e7..ede96df3aad77 100644 --- a/airflow/models/taskinstance.py +++ b/airflow/models/taskinstance.py @@ -1090,7 +1090,7 @@ def are_dependencies_met( if failed: return False - verbose_aware_logger("Dependencies all met for %s", self) + verbose_aware_logger("Dependencies all met for dep_context=%s ti=%s", dep_context.description, self) return True @provide_session @@ -1245,6 +1245,7 @@ def check_and_change_state_before_execution( ignore_depends_on_past=ignore_depends_on_past, wait_for_past_depends_before_skipping=wait_for_past_depends_before_skipping, ignore_task_deps=ignore_task_deps, + description="non-requeueable deps", ) if not self.are_dependencies_met( dep_context=non_requeueable_dep_context, session=session, verbose=True @@ -1274,6 +1275,7 @@ def check_and_change_state_before_execution( wait_for_past_depends_before_skipping=wait_for_past_depends_before_skipping, ignore_task_deps=ignore_task_deps, ignore_ti_state=ignore_ti_state, + description="requeueable deps", ) if not self.are_dependencies_met(dep_context=dep_context, session=session, verbose=True): self.state = State.NONE diff --git a/airflow/ti_deps/dep_context.py b/airflow/ti_deps/dep_context.py index 6f2d603509b28..fbdb81355ab92 100644 --- a/airflow/ti_deps/dep_context.py +++ b/airflow/ti_deps/dep_context.py @@ -77,6 +77,7 @@ class DepContext: ignore_ti_state: bool = False ignore_unmapped_tasks: bool = False finished_tis: list[TaskInstance] | None = None + description: str | None = None have_changed_ti_states: bool = False """Have any of the TIs state's been changed as a result of evaluating dependencies"""