[v3-1-test] Enable ruff PLW1510 rule (#57660) (#57674)

* Enable ruff PLW1510 rule

* Exclude prek check for run_command
(cherry picked from commit a79d8db)

Author: jscheffl

airflow-core/tests/unit/charts/helm_template_generator.py

@@ -141,7 +141,7 @@ def render_chart(
         if show_only:
             for i in show_only:
                 command.extend(["--show-only", i])
-        result = subprocess.run(command, capture_output=True, cwd=chart_dir)
+        result = subprocess.run(command, check=False, capture_output=True, cwd=chart_dir)
         if result.returncode:
             raise HelmFailedError(result.returncode, result.args, result.stdout, result.stderr)
         templates = result.stdout

dev/breeze/src/airflow_breeze/utils/publish_docs_to_s3.py

@@ -123,7 +123,10 @@ def sync_docs_to_s3(self, source: str, destination: str):
             return (0, "")
         get_console().print(f"[info]Syncing {source} to {destination}\n")
         result = subprocess.run(
-            ["aws", "s3", "sync", "--delete", source, destination], capture_output=True, text=True
+            ["aws", "s3", "sync", "--delete", source, destination],
+            check=False,
+            capture_output=True,
+            text=True,
         )
         return (result.returncode, result.stderr)
 

devel-common/src/sphinx_exts/docs_build/docs_builder.py

@@ -192,6 +192,7 @@ def check_spelling(self, verbose: bool) -> tuple[list[SpellingError], list[DocBu
         with open(self.log_spelling_filename, "w") as output:
             completed_proc = run(
                 build_cmd,
+                check=False,
                 cwd=AIRFLOW_CONTENT_ROOT_PATH,
                 env=env,
                 stdout=output if not verbose else None,
@@ -274,6 +275,7 @@ def build_sphinx_docs(self, verbose: bool) -> list[DocBuildError]:
         with open(self.log_build_filename, "w") as output:
             completed_proc = run(
                 build_cmd,
+                check=False,
                 cwd=AIRFLOW_CONTENT_ROOT_PATH,
                 env=env,
                 stdout=output if not verbose else None,

helm-tests/tests/chart_utils/helm_template_generator.py

@@ -203,7 +203,7 @@ def render_chart(
         if show_only:
             for i in show_only:
                 command.extend(["--show-only", i])
-        result = subprocess.run(command, capture_output=True, cwd=chart_dir)
+        result = subprocess.run(command, check=False, capture_output=True, cwd=chart_dir)
         if result.returncode:
             raise HelmFailedError(result.returncode, result.args, result.stdout, result.stderr)
         templates = result.stdout

providers/amazon/src/airflow/providers/amazon/aws/executors/aws_lambda/docker/app.py

@@ -66,7 +66,11 @@ def run_and_report(command, task_key):
     try:
         log.info("Starting execution for task: %s", task_key)
         result = subprocess.run(
-            command, shell=isinstance(command, str), stdout=subprocess.PIPE, stderr=subprocess.STDOUT
+            command,
+            check=False,
+            shell=isinstance(command, str),
+            stdout=subprocess.PIPE,
+            stderr=subprocess.STDOUT,
         )
         return_code = result.returncode
         log.info("Execution completed for task %s with return code %s", task_key, return_code)

providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py

@@ -247,7 +247,14 @@ def _execute_in_subprocess(command_to_exec: CommandType, celery_task_id: str | N
     if celery_task_id:
         env["external_executor_id"] = celery_task_id
     try:
-        subprocess.run(command_to_exec, stderr=sys.__stderr__, stdout=sys.__stdout__, close_fds=True, env=env)
+        subprocess.run(
+            command_to_exec,
+            check=False,
+            stderr=sys.__stderr__,
+            stdout=sys.__stdout__,
+            close_fds=True,
+            env=env,
+        )
     except subprocess.CalledProcessError as e:
         log.exception("[%s] execute_command encountered a CalledProcessError", celery_task_id)
         log.error(e.output)

providers/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py

@@ -1212,7 +1212,7 @@ def _generate_login_token(self, service_account) -> str:
         cloud_sql_hook = CloudSQLHook(api_version="v1", gcp_conn_id=self.gcp_conn_id)
 
         with cloud_sql_hook.provide_authorized_gcloud():
-            proc = subprocess.run(cmd, capture_output=True)
+            proc = subprocess.run(cmd, check=False, capture_output=True)
 
         if proc.returncode != 0:
             stderr_last_20_lines = "\n".join(proc.stderr.decode().strip().splitlines()[-20:])

providers/google/src/airflow/providers/google/cloud/hooks/dataflow.py

@@ -1005,7 +1005,7 @@ def _create_dataflow_job_with_gcloud(self, cmd: list[str]) -> str:
         success_code = 0
 
         with self.provide_authorized_gcloud():
-            proc = subprocess.run(cmd, capture_output=True)
+            proc = subprocess.run(cmd, check=False, capture_output=True)
 
         if proc.returncode != success_code:
             stderr_last_20_lines = "\n".join(proc.stderr.decode().strip().splitlines()[-20:])

providers/google/src/airflow/providers/google/cloud/hooks/dataproc.py

@@ -298,7 +298,7 @@ def _create_dataproc_cluster_with_gcloud(self, cmd: list[str]) -> str:
         success_code = 0
 
         with self.provide_authorized_gcloud():
-            proc = subprocess.run(cmd, capture_output=True)
+            proc = subprocess.run(cmd, check=False, capture_output=True)
 
         if proc.returncode != success_code:
             stderr_last_20_lines = "\n".join(proc.stderr.decode().strip().splitlines()[-20:])

pyproject.toml

@@ -601,6 +601,7 @@ extend-select = [
     "PLW1501", # {mode} is not a valid mode for open
     "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
     "PLW1508", # Invalid type for environment variable default; expected str or None
+    "PLW1510", # subprocess.run without explicit check argument
     # Per rule enables
     "RUF006", # Checks for asyncio dangling task
     "RUF015", # Checks for unnecessary iterable allocation for first element