Skip to content

Commit f3b238a

Browse files
Fix main otel logger test (#42246)
1 parent a5d0a63 commit f3b238a

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

tests/core/test_otel_logger.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,15 +304,25 @@ def test_timer_no_name_returns_float_but_does_not_store_value(self, mock_time, n
304304
assert mock_time.call_count == 2
305305
self.meter.get_meter().create_observable_gauge.assert_not_called()
306306

307+
@pytest.mark.parametrize(
308+
"metrics_consistency_on",
309+
[
310+
True,
311+
False,
312+
],
313+
)
307314
@mock.patch.object(time, "perf_counter", side_effect=[0.0, 3.14])
308-
def test_timer_start_and_stop_manually_send_false(self, mock_time, name):
315+
def test_timer_start_and_stop_manually_send_false(self, mock_time, metrics_consistency_on, name):
316+
protocols.metrics_consistency_on = metrics_consistency_on
317+
309318
timer = self.stats.timer(name)
310319
timer.start()
311320
# Perform some task
312321
timer.stop(send=False)
313322

314323
assert isinstance(timer.duration, float)
315-
assert timer.duration == 3.14
324+
expected_value = 3140.0 if metrics_consistency_on else 3.14
325+
assert timer.duration == expected_value
316326
assert mock_time.call_count == 2
317327
self.meter.get_meter().create_observable_gauge.assert_not_called()
318328

0 commit comments

Comments
 (0)