Skip to content

Commit c8c5b70

Browse files
committed
Migrate remaining providers to common.compat compatibility layer
1 parent 79738ba commit c8c5b70

8 files changed

Lines changed: 10 additions & 20 deletions

File tree

providers/common/sql/pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ dependencies = [
6868
# The optional dependencies should be modified in place in the generated file
6969
# Any change in the dependencies is preserved when the file is regenerated
7070
[project.optional-dependencies]
71+
"common.compat" = [
72+
"apache-airflow-providers-common-compat>=1.7.4", # + TODO: bump to next version
73+
]
7174
"pandas" = [
7275
'pandas[sql-other]>=2.1.2; python_version <"3.13"',
7376
# Technically - we should add "sql-other" here as well, but this will only be possible when we move
@@ -86,6 +89,7 @@ dev = [
8689
"apache-airflow",
8790
"apache-airflow-task-sdk",
8891
"apache-airflow-devel-common",
92+
"apache-airflow-providers-common-compat",
8993
"apache-airflow-providers-openlineage",
9094
# Additional devel dependencies (do not remove this line and add extra development dependencies)
9195
"apache-airflow-providers-common-sql[pandas]",

providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
)
4242
from airflow.providers.common.sql.dialects.dialect import Dialect
4343
from airflow.providers.common.sql.hooks import handlers
44-
from airflow.providers.common.sql.version_compat import BaseHook
44+
from airflow.providers.common.compat.sdk import BaseHook
4545
from airflow.utils.module_loading import import_string
4646

4747
if TYPE_CHECKING:

providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from airflow.exceptions import AirflowException
2525
from airflow.providers.common.sql.hooks.sql import DbApiHook
2626
from airflow.providers.common.sql.triggers.sql import SQLExecuteQueryTrigger
27-
from airflow.providers.common.sql.version_compat import BaseHook, BaseOperator
27+
from airflow.providers.common.compat.sdk import BaseHook, BaseOperator
2828

2929
if TYPE_CHECKING:
3030
import jinja2

providers/common/sql/src/airflow/providers/common/sql/operators/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from airflow.models import SkipMixin
2929
from airflow.providers.common.sql.hooks.handlers import fetch_all_handler, return_single_query_results
3030
from airflow.providers.common.sql.hooks.sql import DbApiHook
31-
from airflow.providers.common.sql.version_compat import BaseHook, BaseOperator
31+
from airflow.providers.common.compat.sdk import BaseHook, BaseOperator
3232
from airflow.utils.helpers import merge_dicts
3333

3434
if TYPE_CHECKING:

providers/common/sql/src/airflow/providers/common/sql/sensors/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
from airflow.exceptions import AirflowException
2424
from airflow.providers.common.sql.hooks.sql import DbApiHook
25-
from airflow.providers.common.sql.version_compat import BaseHook, BaseSensorOperator
25+
from airflow.providers.common.compat.sdk import BaseHook, BaseSensorOperator
2626

2727
if TYPE_CHECKING:
2828
from airflow.utils.context import Context

providers/common/sql/src/airflow/providers/common/sql/triggers/sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
from airflow.exceptions import AirflowException
2323
from airflow.providers.common.sql.hooks.sql import DbApiHook
24-
from airflow.providers.common.sql.version_compat import BaseHook
24+
from airflow.providers.common.compat.sdk import BaseHook
2525
from airflow.triggers.base import BaseTrigger, TriggerEvent
2626

2727
if TYPE_CHECKING:

providers/common/sql/src/airflow/providers/common/sql/version_compat.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,21 +35,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
3535
AIRFLOW_V_3_0_PLUS = get_base_airflow_version_tuple() >= (3, 0, 0)
3636
AIRFLOW_V_3_1_PLUS: bool = get_base_airflow_version_tuple() >= (3, 1, 0)
3737

38-
if AIRFLOW_V_3_1_PLUS:
39-
from airflow.sdk import BaseHook
40-
else:
41-
from airflow.hooks.base import BaseHook # type: ignore[attr-defined,no-redef]
42-
43-
if AIRFLOW_V_3_0_PLUS:
44-
from airflow.sdk import BaseOperator, BaseSensorOperator
45-
else:
46-
from airflow.models import BaseOperator
47-
from airflow.sensors.base import BaseSensorOperator # type: ignore[no-redef]
48-
4938
__all__ = [
5039
"AIRFLOW_V_3_0_PLUS",
5140
"AIRFLOW_V_3_1_PLUS",
52-
"BaseHook",
53-
"BaseOperator",
54-
"BaseSensorOperator",
5541
]

providers/common/sql/tests/unit/common/sql/hooks/test_dbapi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
from airflow.providers.common.sql.dialects.dialect import Dialect
3030
from airflow.providers.common.sql.hooks.handlers import fetch_all_handler, fetch_one_handler
3131
from airflow.providers.common.sql.hooks.sql import DbApiHook
32-
from airflow.providers.common.sql.version_compat import BaseHook
32+
from airflow.providers.common.compat.sdk import BaseHook
3333

3434

3535
class DbApiHookInProvider(DbApiHook):

0 commit comments

Comments
 (0)