Second pass review suggestions by Wei

Author: jscheffl

airflow-core/src/airflow/serialization/serde.py

@@ -368,26 +368,30 @@ def _register():
         for _, module_name, _ in iter_namespace(airflow.serialization.serializers):
             module = import_module(module_name)
             for serializers in getattr(module, "serializers", ()):
-                s = serializers if isinstance(serializers, str) else qualname(serializers)
-                if s in _serializers and _serializers[s] != module:
-                    raise AttributeError(f"duplicate {s} for serialization in {module} and {_serializers[s]}")
-                log.debug("registering %s for serialization", s)
-                _serializers[s] = module
+                s_qualname = serializers if isinstance(serializers, str) else qualname(serializers)
+                if s_qualname in _serializers and _serializers[s_qualname] != module:
+                    raise AttributeError(
+                        f"duplicate {s_qualname} for serialization in {module} and {_serializers[s_qualname]}"
+                    )
+                log.debug("registering %s for serialization", s_qualname)
+                _serializers[s_qualname] = module
             for deserializers in getattr(module, "deserializers", ()):
-                d = deserializers if isinstance(deserializers, str) else qualname(deserializers)
-                if d in _deserializers and _deserializers[d] != module:
+                d_qualname = deserializers if isinstance(deserializers, str) else qualname(deserializers)
+                if d_qualname in _deserializers and _deserializers[d_qualname] != module:
                     raise AttributeError(
-                        f"duplicate {d} for deserialization in {module} and {_deserializers[d]}"
+                        f"duplicate {d_qualname} for deserialization in {module} and {_deserializers[d_qualname]}"
                     )
-                log.debug("registering %s for deserialization", d)
-                _deserializers[d] = module
-                _extra_allowed.add(d)
+                log.debug("registering %s for deserialization", d_qualname)
+                _deserializers[d_qualname] = module
+                _extra_allowed.add(d_qualname)
             for stringifiers in getattr(module, "stringifiers", ()):
-                c = stringifiers if isinstance(stringifiers, str) else qualname(stringifiers)
-                if c in _deserializers and _deserializers[c] != module:
-                    raise AttributeError(f"duplicate {c} for stringifiers in {module} and {_stringifiers[c]}")
-                log.debug("registering %s for stringifying", c)
-                _stringifiers[c] = module
+                c_qualname = stringifiers if isinstance(stringifiers, str) else qualname(stringifiers)
+                if c_qualname in _deserializers and _deserializers[c_qualname] != module:
+                    raise AttributeError(
+                        f"duplicate {c_qualname} for stringifiers in {module} and {_stringifiers[c_qualname]}"
+                    )
+                log.debug("registering %s for stringifying", c_qualname)
+                _stringifiers[c_qualname] = module
 
     log.debug("loading serializers took %.3f seconds", timer.duration)
 

airflow-core/tests/unit/plugins/test_plugin_ignore.py

@@ -104,8 +104,8 @@ def test_find_not_should_ignore_path_glob(self, tmp_path):
         }
         ignore_list_file = ".airflowignore_glob"
         print("-" * 20)
-        for file_path_raw in find_path_from_directory(plugin_folder_path, ignore_list_file, "glob"):
-            file_path = Path(file_path_raw)
+        for raw_file_path in find_path_from_directory(plugin_folder_path, ignore_list_file, "glob"):
+            file_path = Path(raw_file_path)
             if file_path.is_file() and file_path.suffix == ".py":
                 detected_files.add(file_path.name)
                 print(file_path)