Add --list-categories flag to validator#405
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a --list-categories CLI flag to the skill-and-tool-validator that prints every violation category (marking SOFT/advisory ones) and exits, along with a corresponding test.
Changes:
- Introduce
ALL_CATEGORIESfrozenset enumerating every violation category. - Add
--list-categoriesargparse flag and handler inmain(). - Add
test_list_categoriestest covering the new flag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/skill-and-tool-validator/src/skill_and_tool_validator/init.py | Defines ALL_CATEGORIES and implements the --list-categories CLI option. |
| tools/skill-and-tool-validator/tests/test_validator.py | Adds test verifying the listed categories and advisory marking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Can you also fix the prek checks ? |
potiuk
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--list-categoriestoskill-and-tool-validatorso callers can discover valid--skip-categoriesnames without grepping the source(advisory)Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypassesuv run --directory tools/skill-and-tool-validator skill-and-tool-validate --list-categoriesprints sorted categories with advisory markersRFC-AI-0004 compliance
Linked issues
Closes #377
Notes for reviewers (optional)
Discovery flag exits 0 before
run_validation(). Includes all 11 named category constants (tool/capability-sync categories plus the skill-validation set).