Use full module paths (#727)

Author: rhysmeister

roles/mongodb_auth/molecule/default/converge.yml

@@ -45,7 +45,7 @@
     #  when: inventory_hostname  == 'almalinux_8'
 
     - name: Install pymongo
-      pip:
+      ansible.builtin.pip:
         name: pymongo
       when: 
         - ansible_hostname != "debian12"
@@ -57,20 +57,20 @@
       changed_when: False
 
     - name: Enable mongo auth
-      include_role:
+      ansible.builtin.include_role:
         name: community.mongodb.mongodb_auth
 
     - name: Determine openssl version
-      command: openssl version
+      ansible.builtin.command: openssl version
       changed_when: false
       register: openssl
 
     - name: Set mongosh package version
-      set_fact:
+      ansible.builtin.set_fact:
         mongosh_package: "{{ 'mongodb-mongosh-shared-openssl3' if openssl.stdout.startswith('OpenSSL 3') else 'mongodb-mongosh-shared-openssl11' }}"
       when: mongosh_package is not defined
 
     - name: Install MongoDB Shell
-      package:
+      ansible.builtin.package:
         name:
           - "{{ mongosh_package }}"

roles/mongodb_auth/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 # tasks file for mongodb_auth
 - name: Include OS-specific vars
-  include_vars:
+  ansible.builtin.include_vars:
     file: "{{ lookup('first_found', params) }}"
   vars:
     params:
@@ -17,7 +17,7 @@
     - "vars"
 
 - name: Ensure mongod and pyyaml packages are installed
-  package:
+  ansible.builtin.package:
     name:
       - "{{ mongod_package }}"
       # pyyaml is used to validate yaml files on change
@@ -30,13 +30,13 @@
 
 - name: Warn about default credentials
   when: mongodb_admin_pwd == mongodb_default_admin_pwd
-  debug:
+  ansible.builtin.debug:
     msg: "[WARNING] Using default admin credentials for mongodb admin account! Please change them!"
   tags:
     - "debug"
 
 - name: Enable security section in mongod.conf
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/mongod.conf
     regexp: |-
       ^[#'"\s]*security['"]?\s*:
@@ -52,7 +52,7 @@
     - "setup"
 
 - name: Enable authentication in mongod.conf
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: /etc/mongod.conf
     insertafter: '^security:'
     # two space indentation (the default) assumed
@@ -74,7 +74,7 @@
 - name: Restart mongodb to enable auth before adding additional users
   # This allows us to safely assume auth is already enabled when adding more users
   when: _enable_mongo_auth is changed
-  service:
+  ansible.builtin.service:
     name: mongod
     state: restarted
   tags:
@@ -105,7 +105,7 @@
     - "admin_user"
 
 - name: Add additional mongo users
-  include_tasks: mongodb_auth_user.yml
+  ansible.builtin.include_tasks: mongodb_auth_user.yml
   loop: "{{ mongodb_users }}"
   loop_control:
     loop_var: _mongodb_user

roles/mongodb_config/handlers/main.yml

@@ -1,14 +1,14 @@
 ---
 - name: Restart mongod
   listen: Restart mongod service
-  service:
+  ansible.builtin.service:
     name: "{{ mongod_service }}"
     state: restarted
   when: not skip_restart
 
 - name: Wait for port to become active
   listen: Restart mongod service
-  wait_for:
+  ansible.builtin.wait_for:
     host: "{{ bind_ip | split(',') | first }}"
     port: "{{ config_port }}"
   when: not skip_restart

roles/mongodb_config/molecule/custom_db_path/converge.yml

@@ -11,22 +11,22 @@
   tasks:
 
     - name: Install pymongo
-      pip:
+      ansible.builtin.pip:
         name: "{{ 'pymongo==3.12.*' if ansible_python_version[0:3] | float < 3.6 else 'pymongo' }}"
       when: inventory_hostname == "ubuntu2204"
 
     - name: Determine openssl version
-      command: openssl version
+      ansible.builtin.command: openssl version
       changed_when: false
       register: openssl
 
     - name: Set mongosh package version
-      set_fact:
+      ansible.builtin.set_fact:
         mongosh_package: "{{ 'mongodb-mongosh-shared-openssl3' if openssl.stdout.startswith('OpenSSL 3') else 'mongodb-mongosh-shared-openssl11' }}"
       when: mongosh_package is not defined
 
     - name: Install MongoDB Shell
-      package:
+      ansible.builtin.package:
         name:
           - "{{ mongosh_package }}"
 

roles/mongodb_config/molecule/custom_db_path/prepare.yml

@@ -25,7 +25,7 @@
     when: ansible_os_family == "RedHat"
 
   - name: Update the APT cache on Debian-based systems
-    apt:
+    ansible.builtin.apt:
       update_cache: yes
     when: ansible_os_family == "Debian"
 

roles/mongodb_config/tasks/main.yml

@@ -17,7 +17,7 @@
     "vars"
 
 - name: Ensure mongod package is installed
-  package:
+  ansible.builtin.package:
     name: "{{ mongod_package }}"
   register: _pkg
   until: _pkg is succeeded
@@ -28,7 +28,7 @@
     - "mongodb"
 
 - name: Ensure db_path dir exists
-  file:
+  ansible.builtin.file:
     path: "{{ db_path }}"
     state: directory
     owner: "{{ mongodb_user }}"
@@ -38,7 +38,7 @@
     - "mongodb"
 
 - name: Copy config file
-  template:
+  ansible.builtin.template:
     src: "{{ mongod_config_template }}"
     dest: /etc/mongod.conf
     owner: "{{ mongodb_user }}"
@@ -50,7 +50,7 @@
     - "mongodb"
 
 - name: Copy keyfile to host
-  copy:
+  ansible.builtin.copy:
     content: |
       {{ openssl_keyfile_content }}
     dest: "{{ openssl_keyfile_path }}"
@@ -64,13 +64,13 @@
     - "mongodb"
 
 - name: Check for github override
-  set_fact:
+  ansible.builtin.set_fact:
     x_github_override: "{{ lookup('env', 'X_GITHUB_OVERRIDE') | default('0', True) }}"
   tags:
     - "ci"
 
 - name: Start mongod service
-  service:
+  ansible.builtin.service:
     name: "{{ mongod_service }}"
     state: started
     enabled: yes

roles/mongodb_install/molecule/default/prepare.yml

@@ -6,10 +6,10 @@
   tasks:
 
     - name: Update the APT cache on Debian-based systems
-      apt:
+      ansible.builtin.apt:
         update_cache: yes
       when: ansible_os_family == "Debian"
 
     - name: Install openssl
-      package:
+      ansible.builtin.package:
         name: "openssl"

roles/mongodb_install/molecule/mongodb_hold_packages/prepare.yml

@@ -6,16 +6,16 @@
   tasks:
 
     - name: Required packages
-      yum:
+      ansible.builtin.yum:
         name: yum-plugin-versionlock
         state: present
       when: ansible_facts.os_family == "RedHat"
 
     - name: Update the APT cache on Debian-based systems
-      apt:
+      ansible.builtin.apt:
         update_cache: yes
       when: ansible_os_family == "Debian"
 
     - name: Install openssl
-      package:
+      ansible.builtin.package:
         name: "openssl"

roles/mongodb_install/molecule/mongodb_nohold_packages/prepare.yml

@@ -6,16 +6,16 @@
   tasks:
 
     - name: Required packages
-      yum:
+      ansible.builtin.yum:
         name: yum-plugin-versionlock
         state: present
       when: ansible_facts.os_family == "RedHat"
 
     - name: Update the APT cache on Debian-based systems
-      apt:
+      ansible.builtin.apt:
         update_cache: yes
       when: ansible_os_family == "Debian"
 
     - name: Install openssl
-      package:
+      ansible.builtin.package:
         name: "openssl"

roles/mongodb_install/molecule/specific_mongodb_version/prepare.yml

@@ -6,16 +6,16 @@
   tasks:
 
     - name: Required packages
-      yum:
+      ansible.builtin.yum:
         name: yum-plugin-versionlock
         state: present
       when: ansible_facts.os_family == "RedHat"
 
     - name: Update the APT cache on Debian-based systems
-      apt:
+      ansible.builtin.apt:
         update_cache: yes
       when: ansible_os_family == "Debian"
 
     - name: Install openssl
-      package:
+      ansible.builtin.package:
         name: "openssl"