fix(@angular/build): #31973 Added JavaScriptTransformer close to dispose method

This change allows for awaiting the disposed plugin and added the
missing close method of the JavaScript transformer to the onDispose.
When the plugin is run multiple times on different projects/bundles
without proper closing it will result in a node heap corruption. This
allows us to cleanup the build before we start a new one.

fix(@angular/build): #31973 - Disable linting warning in onDispose

ESbuild will still treat this as a void and this bypass allows for
breaking free of the forced fire-and-forget. Functionally this will have
no impact on current behavior, it just adds some extra freedom to
potentially process and await the Promise.

Update packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts

Co-authored-by: Alan Agius <[email protected]>

Author: Aukevanoost

packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts

@@ -588,11 +588,13 @@ export function createCompilerPlugin(
         logCumulativeDurations();
       });
 
-      build.onDispose(() => {
-        sharedTSCompilationState?.dispose();
-        void compilation.close?.();
-        void cacheStore?.close();
-      });
+      // eslint-disable-next-line @typescript-eslint/no-misused-promises
+      build.onDispose(() =>
+        void Promise.all(
+          [compilation?.close?.(), cacheStore?.close(), javascriptTransformer.close()].filter(
+            Boolean,
+          ),
+        ).then(() => sharedTSCompilationState?.dispose());
 
       /**
        * Checks if the file has side-effects when `advancedOptimizations` is enabled.