Skip to content

Commit d827e03

Browse files
committed
Disables the user lookup endpoint
1 parent f9c0819 commit d827e03

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

aleph/tests/test_roles_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def test_suggest(self):
2020
_, headers = self.login(is_admin=True)
2121
res = self.client.get("/api/2/roles/_suggest?prefix=user", headers=headers)
2222
assert res.status_code == 200, res
23-
assert res.json["total"] >= 3, res.json
23+
assert res.json["total"] == 0, res.json
2424

2525
def test_view(self):
2626
res = self.client.get("/api/2/roles/%s" % self.rolex)

aleph/views/roles_api.py

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
import logging
2-
from banal import ensure_list
32
from flask_babel import gettext
43
from flask import Blueprint, request
54
from itsdangerous import BadSignature
65
from werkzeug.exceptions import BadRequest
76

87
from aleph.core import db
98
from aleph.authz import Authz
10-
from aleph.search import QueryParser, DatabaseQueryResult
119
from aleph.model import Role
1210
from aleph.logic.roles import challenge_role, update_role, create_user, get_deep_role
1311
from aleph.util import is_auto_admin
@@ -53,22 +51,12 @@ def suggest():
5351
- Role
5452
"""
5553
require(request.authz.logged_in)
56-
parser = QueryParser(request.args, request.authz, limit=10)
57-
if parser.prefix is None or len(parser.prefix) < 3:
58-
# Do not return 400 because it's a routine event.
59-
return jsonify(
60-
{
61-
"status": "error",
62-
"message": gettext("prefix filter is too short"),
63-
"results": [],
64-
"total": 0,
65-
}
66-
)
67-
# this only returns users, not groups
68-
exclude = ensure_list(parser.excludes.get("id"))
69-
q = Role.by_prefix(parser.prefix, exclude=exclude)
70-
result = DatabaseQueryResult(request, q, parser=parser)
71-
return RoleSerializer.jsonify_result(result)
54+
return jsonify(
55+
{
56+
"results": [],
57+
"total": 0,
58+
}
59+
)
7260

7361

7462
@blueprint.route("/api/2/roles/code", methods=["POST"])

0 commit comments

Comments
 (0)