Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Hide popover when doc is edited or changes #3538

Merged
peterflynn merged 6 commits into from
Apr 24, 2013
Merged

Hide popover when doc is edited or changes #3538

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e80650
hide popover when doc is edited or changes
redmunds Apr 22, 2013
ac46828
merge with master
redmunds Apr 23, 2013
942d4d1
use getActiverEditor()
redmunds Apr 23, 2013
3f866ac
activeEditorChange gets called same time as currentDocumentChange, so…
redmunds Apr 23, 2013
1030dcf
no need to keep track of doc we're listening to
redmunds Apr 23, 2013
b7ac07a
Ensure disabling Hover Preview detaches its listener from whatever do…
peterflynn Apr 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/extensions/default/HoverPreview/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ define(function (require, exports, module) {
// Brackets modules
var AppInit = brackets.getModule("utils/AppInit"),
CommandManager = brackets.getModule("command/CommandManager"),
DocumentManager = brackets.getModule("document/DocumentManager"),
EditorManager = brackets.getModule("editor/EditorManager"),
ExtensionUtils = brackets.getModule("utils/ExtensionUtils"),
Menus = brackets.getModule("command/Menus"),
Expand Down Expand Up @@ -425,7 +426,19 @@ define(function (require, exports, module) {
}
}


function onActiveEditorChange(event, current, previous) {
// Hide preview when editor changes
hidePreview();

if (previous && previous.document) {
$(previous.document).off("change", hidePreview);
}

if (current && current.document) {
$(current.document).on("change", hidePreview);
}
}

// Menu command handlers
function updateMenuItemCheckmark() {
CommandManager.get(CMD_ENABLE_HOVER_PREVIEW).setChecked(enabled);
Expand All @@ -440,9 +453,19 @@ define(function (require, exports, module) {
// we auto-hide on text edit, which is probably actually a good thing.
editorHolder.addEventListener("mousemove", handleMouseMove, true);
editorHolder.addEventListener("scroll", hidePreview, true);

// Setup doc "change" listener
onActiveEditorChange(null, EditorManager.getActiveEditor(), null);
$(EditorManager).on("activeEditorChange", onActiveEditorChange);

} else {
editorHolder.removeEventListener("mousemove", handleMouseMove, true);
editorHolder.removeEventListener("scroll", hidePreview, true);

// Cleanup doc "change" listener
onActiveEditorChange(null, null, EditorManager.getActiveEditor());
$(EditorManager).off("activeEditorChange", onActiveEditorChange);

hidePreview();
}
prefs.setValue("enabled", enabled);
Expand Down